From: Linus Walleij <linus.walleij@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Icenowy Zheng <uwu@icenowy.me>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RFC PATCH 0/2] pinctrl: sunxi: Introduce DT-based pinctrl builder
Date: Thu, 10 Nov 2022 11:21:02 +0100 [thread overview]
Message-ID: <CACRpkdb=5mobcWBJYtXd=nC7A+Uo__itk0F9oZBeTjWHBkBU1w@mail.gmail.com> (raw)
In-Reply-To: <20221110014255.20711-1-andre.przywara@arm.com>
On Thu, Nov 10, 2022 at 2:44 AM Andre Przywara <andre.przywara@arm.com> wrote:
> Compared to my previous effort almost exactly five years ago [1], this
> new version drops the idea of describing the pinctrl data entirely in
> the DT, instead it still relies on driver provided information for that.
(...)
> On the DT side all that would be needed is *one* extra property per
> pin group to announce the mux value:
>
> uart0_pb_pins: uart0-pb-pins {
> pins = "PB9", "PB10";
> function = "uart0";
> pinmux = <2>;
> };
So what you need to do is to convince the device tree people that this
is a good idea.
For me as linux maintainer it's no big deal, it's fine either way. The new
code looks elegant.
But from a DT point of view this needs to make sense also for Windows
and BSD, so that is who you have to convince. If it is possible to derive
the same information from the compatible string (like today) that will
need an extended argument why all operating systems will benefit from
this.
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-11-10 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 1:42 [RFC PATCH 0/2] pinctrl: sunxi: Introduce DT-based pinctrl builder Andre Przywara
2022-11-10 1:42 ` [RFC PATCH 1/2] pinctrl: sunxi: allow reading mux values from DT Andre Przywara
2022-11-10 1:42 ` [RFC PATCH 2/2] pinctrl: sunxi: Add support for the Allwinner V5 pin controller Andre Przywara
2022-11-10 10:21 ` Linus Walleij [this message]
2022-11-10 11:33 ` [RFC PATCH 0/2] pinctrl: sunxi: Introduce DT-based pinctrl builder Andre Przywara
2022-11-10 12:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb=5mobcWBJYtXd=nC7A+Uo__itk0F9oZBeTjWHBkBU1w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).