From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] pinctrl: armada-37xx: remove unused variable Date: Fri, 3 Nov 2017 08:46:06 +0100 Message-ID: References: <20171102142932.774199-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171102142932.774199-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ken Ma , Thierry Reding , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Thu, Nov 2, 2017 at 3:29 PM, Arnd Bergmann wrote: > A cleanup left behind a temporary variable that is now unused: > > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c: In function 'armada_37xx_irq_startup': > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:693:20: error: unused variable 'chip' [-Werror=unused-variable] > > This removes the declarations as well. > > Fixes: 3ee9e605caea ("pinctrl: armada-37xx: Stop using struct gpio_chip.irq_base") > Signed-off-by: Arnd Bergmann It is used on the head of development, so it's fixed in -next. Is it such a big issue for v4.14 that you think I should send it to Torvalds as a fix at this point or can I just leave it? Yours, Linus Walleij