linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
	naresh.solanki@9elements.com,  broonie@kernel.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] pinctrl: cy8c95x0: Use single I2C lock
Date: Tue, 28 May 2024 13:58:37 +0200	[thread overview]
Message-ID: <CACRpkdbFVpZhF_RZEeZf06PRq-Sf1Z-8apUbnaJAFDaQt_5xMQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfpFtYtStacY68-iu32x-XK3XMn_34N7EH07vvhjwp36g@mail.gmail.com>

On Tue, May 21, 2024 at 7:25 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, May 21, 2024 at 6:26 PM Patrick Rudolph
> <patrick.rudolph@9elements.com> wrote:
> >
> > Currently there are 3 locks being used when accessing the chip, one
> > in the driver and one in each regmap. Reduce that to one driver only
> > lock that protects all regmap and regcache accesses.
>
> Right. But please consider converting the driver to use cleanup.h.
> Dunno if it requires a separate patch or can be folded into this one
> as it seems you anyway touch almost all mutex calls in the code.
> Linus?

I think it's best to add a separate patch for this for bisection,
just right after this one.

Yours,
Linus Walleij

  reply	other threads:[~2024-05-28 11:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 15:25 [PATCH 1/3] pinctrl: cy8c95x0: Use single I2C lock Patrick Rudolph
2024-05-21 15:25 ` [PATCH 2/3] pinctrl: cy8c95x0: Use regmap ranges Patrick Rudolph
2024-05-21 17:34   ` Andy Shevchenko
2024-06-07 20:29     ` Andy Shevchenko
2024-08-09 12:13   ` Andy Shevchenko
2024-08-20  8:30     ` Patrick Rudolph
2024-08-20 16:18       ` Andy Shevchenko
2024-08-26  8:26   ` Linus Walleij
2024-05-21 15:25 ` [PATCH 3/3] pinctrl: cy8c95x0: Use REGCACHE_MAPLE Patrick Rudolph
2024-05-21 17:35   ` Andy Shevchenko
2024-05-21 17:24 ` [PATCH 1/3] pinctrl: cy8c95x0: Use single I2C lock Andy Shevchenko
2024-05-28 11:58   ` Linus Walleij [this message]
2024-06-07 20:26 ` Andy Shevchenko
2024-06-07 20:38 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdbFVpZhF_RZEeZf06PRq-Sf1Z-8apUbnaJAFDaQt_5xMQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naresh.solanki@9elements.com \
    --cc=patrick.rudolph@9elements.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).