Re: [PATCH 05/10] pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.

Re: [PATCH 05/10] pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.

[Lee Jones]

On Wed, 13 May 2015, Hongzhou Yang wrote:

> Add mt6397 support using mediatek common pinctrl driver.
> 
> mt6397 is a PMIC, and pinctrl/GPIO is part of 6397 chip.
> Pinctrl/GPIO driver should obtain regmap from PMIC,
> so adding this support to common code.
> 
> Also, mt6397 is no need to support interrupt controller,
> so changing common code to skip it.
> 
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> ---
>  drivers/mfd/mt6397-core.c                     |    3 +

Please break this out into a separate patch that I can take through my
tree.  There is no need for you to bind up changes in multiple
subsystems here.

>  drivers/pinctrl/mediatek/Kconfig              |    6 +
>  drivers/pinctrl/mediatek/Makefile             |    1 +
>  drivers/pinctrl/mediatek/pinctrl-mt6397.c     |   78 +++++
>  drivers/pinctrl/mediatek/pinctrl-mt8135.c     |    2 +-
>  drivers/pinctrl/mediatek/pinctrl-mt8173.c     |    2 +-
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.c |   13 +-
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.h |    3 +-
>  drivers/pinctrl/mediatek/pinctrl-mtk-mt6397.h |  424 +++++++++++++++++++++++++
>  9 files changed, 527 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt6397.c
>  create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt6397.h
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..012c620 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mediatek-mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/10] pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.

[Hongzhou Yang]

On Thu, 2015-05-14 at 08:22 +0100, Lee Jones wrote:
> On Wed, 13 May 2015, Hongzhou Yang wrote:
> 
> > Add mt6397 support using mediatek common pinctrl driver.
> > 
> > mt6397 is a PMIC, and pinctrl/GPIO is part of 6397 chip.
> > Pinctrl/GPIO driver should obtain regmap from PMIC,
> > so adding this support to common code.
> > 
> > Also, mt6397 is no need to support interrupt controller,
> > so changing common code to skip it.
> > 
> > Signed-off-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> >  drivers/mfd/mt6397-core.c                     |    3 +
> 
> Please break this out into a separate patch that I can take through my
> tree.  There is no need for you to bind up changes in multiple
> subsystems here.

Ok, I will separate it, thank you.

Yours,
Hongzhou

Re: Mediatek pinctrl driver optimize and add Mediatek SoC Pinctrl/GPIO/EINT driver for mt6397/mt8127.

[Yingjoe Chen]

On Wed, 2015-05-13 at 18:35 -0700, Hongzhou Yang wrote:
> This series patches include below changes:
>   - Data struct optimize and remove unused member.
>   - Since several mediatek soc use similiar input enable/smt/pull setting, add those settings into common code.
>   - The first version of adding Mediatek SoC Pinctrl/GPIO driver for mt6397, mt6397 has 41 pins.
>   - The first version of adding Mediatek SoC Pinctrl/GPIO/EINT driver for mt8127, mt8127 has 143 pins.
> 
> 
> Hongzhou Yang (6):
>   pinctrl: mediatek: add ies/smt control to common code.
>   dt-bindings: mediatek: Modify pinctrl bindings for mt6397.
>   pinctrl: mediatek: Add Pinctrl/GPIO driver for mt6397.
>   pinctrl: dt bindings: mt6397: Add pinfunc header file for mt6397.
>   arm64: dts: mt8173-evb: Add pinctrl/GPIO node for mt6397.
>   ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.
> 
> Yingjoe Chen (4):
>   pinctrl: mediatek: data struct optimize and remove unused member
>   pinctrl: mediatek: add mtk_pctrl_spec_pull_set_samereg common code
>   pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt8127
>   ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127


Hi,

There are several patches in this series, and they should go to
different trees. Will it be easier for maintainers if we rearrange
patches in the following order?

  dt-bindings: mediatek: Modify pinctrl bindings for mt6397.
  pinctrl: dt bindings: mt6397: Add pinfunc header file for mt6397.
  pinctrl: mediatek: data struct optimize and remove unused member
  pinctrl: mediatek: add mtk_pctrl_spec_pull_set_samereg common code
  pinctrl: mediatek: add ies/smt control to common code.
  pinctrl: mediatek: add Pinctrl/GPIO driver for mt6397.
  pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt8127
  mfd: mediatek: add GPIO sub module support into mfd.
  ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127
  arm64: dts: mt8173-evb: add pinctrl/GPIO node for mt6397.
  ARM: dts: mt8135-evbp1: add pinctrl/GPIO node for mt6397.

To avoid build fail, the last 2 should not be merged until the second
one is merged into mainline.

Joe.C

Re: [PATCH 01/10] pinctrl: mediatek: data struct optimize and remove unused member

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> From: Yingjoe Chen <yingjoe.chen@mediatek.com>
>
> struct mtk_desc_pin.chip, mtk_pinctrl_devdata.invser_offset
> and mtk_pinctrl_devdata.chip_type are never used in code.
> Remove them.
>
> Some per-pin data are using int for pin number and offsets.
> Change to short and rearrange to reduce const data size.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Patch applied.

However I suggest you use:

unsigned int => u32
unsigned short => u16
unsigned char => u8

These kernel-specific types are more to the point,
you immediately see how many bits they use, so a
patch chaning all of the types to u32/u16/u8 would
be welcome.

Yours,
Linus Walleij

Re: [PATCH 02/10] pinctrl: mediatek: add mtk_pctrl_spec_pull_set_samereg common code

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> From: Yingjoe Chen <yingjoe.chen@mediatek.com>
>
> Several mediatek soc use similar pull setting procedure as mt8173,
> the pupd enable and resistance setting are in the same register.
> Add common code mtk_pctrl_spec_pull_set_samereg out of spec_pull_set
> in mt8173 to handle this case, so future soc driver can use it.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Patch applied.

Yours,
Linus Walleij

Re: [PATCH 03/10] pinctrl: mediatek: add ies/smt control to common code.

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> Input enable and smt setting have different register,
> modify code to fix it.
>
> Several mediatek soc use similar input enable/smt setting
> procedure as mt8173, some soc use generic input enable/smt
> setting, some soc has no input enable/smt setting. Adding
> common code to handle all those cases, so future soc driver
> can use it.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Patch applied.

Yours,
Linus Walleij

Re: [PATCH 04/10] dt-bindings: mediatek: Modify pinctrl bindings for mt6397.

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> Since 6397 is no need to support interrupt controller,
> moving interrupt controller relate property to optional list.
> Also adding mt8173 and mt8127 to bindings.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Patch applied. (Modified subject slightly.)

Yours,
Linus Walleij

Re: [PATCH 06/10] pinctrl: dt bindings: mt6397: Add pinfunc header file for mt6397.

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:

> Add pinfunc header file, mt8135/mt8173 relate dts will include it.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] arm64: dts: mt8173-evb: Add pinctrl/GPIO node for mt6397.

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> Add pinctrl and GPIO node to mt8173-evb.dts.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

This needs to go through the ARM SoC tree, or I need an ACK from
some ARM SoC maintainer if I should take it through the pinctrl
tree.

Since there is a build dependency on the header in pinctrl
ARM SoC would need to pull in some immutable branch
from my tree to take this patch.

Yours,
Linus Walleij

Re: [PATCH 08/10] ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:

> Add pinctrl and GPIO node to mt8135-evbp1.dts.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Same comment as on patch 7.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/10] ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.

[Matthias Brugger]

2015-05-19 10:57 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
> On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
> <hongzhou.yang@mediatek.com> wrote:
>
>> Add pinctrl and GPIO node to mt8135-evbp1.dts.
>>
>> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>

Acked-by: Matthias Brugger <matthias.bgg@gmail.com>

Linus, please take it through your tree.
Thanks.

-- 
motzblog.wordpress.com

Re: [PATCH 08/10] ARM: dts: mt8135-evbp1: Add pinctrl/GPIO node for mt6397.

[Matthias Brugger]

2015-05-21 9:53 GMT+02:00 Matthias Brugger <matthias.bgg@gmail.com>:
> 2015-05-19 10:57 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
>> On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
>> <hongzhou.yang@mediatek.com> wrote:
>>
>>> Add pinctrl and GPIO node to mt8135-evbp1.dts.
>>>
>>> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Linus, please take it through your tree.
> Thanks.

Wrong series, please forget about this mail.
Sorry for the noise.

-- 
motzblog.wordpress.com

Re: [PATCH 09/10] pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt8127

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> From: Yingjoe Chen <yingjoe.chen@mediatek.com>
>
> MT8127 pinctrl/eint are similar to mt8135 and mt8173, add
> support for mt8127 using mediatek common pinctrl driver.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Patch applied. Needed some fuzzing in the Makefile,
check result in my devel branch or linux-next.

Yours,
Linus Walleikj

Re: [PATCH 10/10] ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127

[Linus Walleij]

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> From: Yingjoe Chen <yingjoe.chen@mediatek.com>
>
> Add pinctrl,GPIO and EINT node to mt8127.dtsi.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Same comment as on patch 7.

Yours,
Linus Walleij

Re: [PATCH 10/10] ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127

[Matthias Brugger]

2015-05-19 11:02 GMT+02:00 Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
> On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
> <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
>
>> From: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>
>> Add pinctrl,GPIO and EINT node to mt8127.dtsi.
>>
>> Signed-off-by: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Linus, please take it through your tree.
Thanks.

-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/10] ARM: dts: mt8127: add pinctrl/GPIO/EINT node for mt8127

[Matthias Brugger]

2015-05-21 9:54 GMT+02:00 Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> 2015-05-19 11:02 GMT+02:00 Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
>> On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
>> <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
>>
>>> From: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>>
>>> Add pinctrl,GPIO and EINT node to mt8127.dtsi.
>>>
>>> Signed-off-by: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>> Signed-off-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>
>> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Acked-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Linus, please take it through your tree.
> Thanks.

Wrong series, please forget about this mail.
Sorry for the noise.


-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html