From: Linus Walleij <linus.walleij@linaro.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
andy.shevchenko@gmail.com, "Philip Howard" <phil@gadgetoid.com>,
"Sean Young" <sean@mess.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Stefan Wahren" <wahrenst@gmx.net>,
linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Nicola Di Lieto <nicola.dilieto@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio
Date: Tue, 4 Jun 2024 15:38:41 +0200 [thread overview]
Message-ID: <CACRpkdbPGEx9QSazVfP7rbkM7x2MnJbrACdTi3zyniQhZSyTbw@mail.gmail.com> (raw)
In-Reply-To: <20240602-pwm-gpio-v6-1-e8f6ec9cc783@linaro.org>
Some buzz around the patch made me notice this:
On Sun, Jun 2, 2024 at 10:33 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> + "#pwm-cells":
> + const: 3
I guess we should document these three cells:
- First cell must be 0 - just the one PWM on the one GPIO pin
- Second cell should be the default period that can be changed by software
- Third cell is polarity, 0 or PWM_POLARITY_INVERTED
I guess this is 3 not 2 because the maintainers previously said they wanted
it like this? (I haven't read all old mail, nor do I remember...)
The #pwm-cells are currently not properly specified in the bindings: for example
pwm-tiecap.yaml says "See pwm.yaml in this directory for a description
of the cells format."
and that file says nothing about the cells and what they are for, should
I send a separate patch for that?
Yours,
Linus Walleij
next prev parent reply other threads:[~2024-06-04 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 20:33 [PATCH v6 0/2] pwm: Add GPIO PWM driver Linus Walleij
2024-06-02 20:33 ` [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio Linus Walleij
2024-06-04 2:51 ` Kent Gibson
2024-06-04 6:21 ` Krzysztof Kozlowski
2024-06-04 7:34 ` Kent Gibson
2024-06-04 7:42 ` Krzysztof Kozlowski
2024-06-04 8:16 ` Kent Gibson
2024-06-04 8:26 ` Krzysztof Kozlowski
2024-06-04 13:38 ` Linus Walleij [this message]
2024-06-04 14:14 ` Conor Dooley
2024-06-04 20:54 ` Linus Walleij
2024-06-05 17:23 ` Conor Dooley
2024-06-02 20:33 ` [PATCH v6 2/2] pwm: Add GPIO PWM driver Linus Walleij
2024-06-03 20:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbPGEx9QSazVfP7rbkM7x2MnJbrACdTi3zyniQhZSyTbw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=nicola.dilieto@gmail.com \
--cc=phil@gadgetoid.com \
--cc=robh@kernel.org \
--cc=sean@mess.org \
--cc=ukleinek@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).