From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 3/5] pinctrl: add helpers reading pins, groups & functions from DT
Date: Mon, 22 Nov 2021 00:53:15 +0100 [thread overview]
Message-ID: <CACRpkdbQ8fEfWqkb+R0xDPAdeenWQKmXqtO49Hfh7V84Zqospg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VebQKsSJYxK9Fi0wEhGfpR=1HZfDsVuqV8BCG-UrZDtVg@mail.gmail.com>
On Thu, Nov 18, 2021 at 2:58 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Nov 18, 2021 at 3:22 PM Rafał Miłecki <zajec5@gmail.com> wrote:
> > +#include <linux/of.h>
>
> I don't like this. This shows not thought through the design of the series.
>
> What I rather expect is a proper interfacing layer that you fill with
> options that can be provided by corresponding underlying
> implementation, e.g. DT.
I agree, the DT parts should land in pinctrl/devicetree.c in the
end with an opt-in for ACPI & board files. I don't know if we
can use software nodes fully instead of board file-specific
helpers at this point, it seems to have
grown pretty competent.
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-11-21 23:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:21 [PATCH 0/5] pinctrl: allow storing pins, groups & functions in DT Rafał Miłecki
2021-11-18 13:21 ` [PATCH 1/5] dt-bindings: pinctrl: support specifying pins, groups & functions Rafał Miłecki
2021-11-18 13:21 ` [PATCH 2/5] dt-bindings: pinctrl: brcm,ns-pinmux: extend example Rafał Miłecki
2021-11-18 22:09 ` Rob Herring
2021-11-19 6:24 ` Rafał Miłecki
2021-11-23 7:38 ` Tony Lindgren
2021-11-23 7:56 ` Rafał Miłecki
2021-11-23 8:01 ` Rafał Miłecki
2021-11-23 9:15 ` Tony Lindgren
2021-11-23 13:51 ` Rafał Miłecki
2021-11-18 13:21 ` [PATCH 3/5] pinctrl: add helpers reading pins, groups & functions from DT Rafał Miłecki
2021-11-18 13:57 ` Andy Shevchenko
2021-11-18 14:17 ` Rafał Miłecki
2021-11-18 16:22 ` Andy Shevchenko
2021-11-21 23:53 ` Linus Walleij [this message]
2021-11-18 13:21 ` [PATCH 4/5] pinctrl: bcm: pinctrl-ns: supoprt DT specified pins, groups & functions Rafał Miłecki
2021-11-18 13:21 ` [PATCH 5/5] ARM: dts: BCM5301X: add pinctrl " Rafał Miłecki
2021-11-18 13:52 ` [PATCH 0/5] pinctrl: allow storing pins, groups & functions in DT Andy Shevchenko
2021-11-18 13:59 ` Rafał Miłecki
2021-11-18 16:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbQ8fEfWqkb+R0xDPAdeenWQKmXqtO49Hfh7V84Zqospg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).