From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jing Xiang <jxiang@marvell.com>,
Xiangzhan Meng <mengxzh@marvell.com>
Subject: Re: [PATCH 3/3] gpio: pxa: add PXA1928 gpio type support
Date: Tue, 3 Feb 2015 13:41:57 +0100 [thread overview]
Message-ID: <CACRpkdbTSh2ZOEpVkCk_QtH44C-hq=8qw-EanHUyD_6fSU_sog@mail.gmail.com> (raw)
In-Reply-To: <1422333966-18338-4-git-send-email-robh@kernel.org>
On Tue, Jan 27, 2015 at 5:46 AM, Rob Herring <robh@kernel.org> wrote:
> Add support for PXA1928 GPIOs. The PXA1928 adds a 6th bank from previous
> generations.
>
> Signed-off-by: Jing Xiang <jxiang@marvell.com>
> Signed-off-by: Xiangzhan Meng <mengxzh@marvell.com>
> [robh: ported to 3.19 from vendor kernel]
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
Patch applied...
> -#define BANK_OFF(n) (((n) < 3) ? (n) << 2 : 0x100 + (((n) - 3) << 2))
> +#define BANK_OFF(n) (((n) < 3) ? (n) << 2 : ((n) > 5 ? 0x200 : 0x100) \
> + + (((n) % 3) << 2))
While this is a bit convoluted.
Someone care to send a patch converting it to something like a
parseable static inline?
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-02-03 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 4:46 [PATCH 0/3] PXA1928 GPIO support Rob Herring
2015-01-27 4:46 ` [PATCH 1/3] gpio: pxa: remove mach IRQ includes Rob Herring
2015-02-03 12:38 ` Linus Walleij
2015-01-27 4:46 ` [PATCH 2/3] dt/bindings: gpio: add compatible string for marvell,pxa1928-gpio Rob Herring
2015-02-03 12:39 ` Linus Walleij
2015-01-27 4:46 ` [PATCH 3/3] gpio: pxa: add PXA1928 gpio type support Rob Herring
2015-02-03 12:41 ` Linus Walleij [this message]
2015-02-03 13:44 ` Rob Herring
2015-03-02 14:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbTSh2ZOEpVkCk_QtH44C-hq=8qw-EanHUyD_6fSU_sog@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=jxiang@marvell.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengxzh@marvell.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).