From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1502C19C561 for ; Thu, 5 Sep 2024 13:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725541985; cv=none; b=SWJ+bLpZLcUYinh7Ob3rcUdVP6UBlLhGKjHX26/Vvt7PuZIf8Idt++g69bDZPVs2Ap6RDhmDVBXJUZHa6MFivX0oqUW/mIPNMEIb9pYSJ7Wp3KU/1KsmI9dnMjdkWDoIhhiSEeeeNAc7XM/xlfFvFZB9gPQMPYmWtXK9h18ibwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725541985; c=relaxed/simple; bh=h+8Hj5/BortzLMQ+9TV7xX2K37XjQFK+vsFCQRMXKNs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=p20TM9eH7sZUAau1gscYyMSTWed3eTbmQ62A7COKomUzAYZQsv8fBhAmbN381H5Dy+Mhasp4Qe+eCTbfIi83Z08CLBpiFI1hpXaO4ZWT5wtwy5AtKG6g0uCWsbpKGTRfhREiCznmtonPx+4THYvZE4HGulXQD9HwbXWu9yT9vBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ksjVNwCk; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ksjVNwCk" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5353cd18c20so895315e87.0 for ; Thu, 05 Sep 2024 06:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725541982; x=1726146782; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h+8Hj5/BortzLMQ+9TV7xX2K37XjQFK+vsFCQRMXKNs=; b=ksjVNwCk72mVLyt1ZTygVJeKccjH5swn1QfdYxteyu+Gl0o5sCm055vvcVgV+YWNs7 l/TG9T9QD5m+jsrjM1wLKz6dXIWXSwArGDTqnjIourTv4QDnUw9l1Mgp54XNTRoHNbJw AfbdlX4E6pTd6jrjva6Gx9iC5zMI4lWfeQ7M+f+xSYgB9MTzU1FjPNZ6TCpnR2ZpfNM6 gn0Unh+GL/ELlhzwVNkIbJOGPDUlLUELgAaGL2sp8EuWLtNe68xz45iPATJ16AsBAfEg LZ2HzEqY+7w2BsR/0FB9ZSe6gz2mVmKWy/5fTfU659P5C1DVk6yruk1UKKD8oaSt2VhS nnjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725541982; x=1726146782; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h+8Hj5/BortzLMQ+9TV7xX2K37XjQFK+vsFCQRMXKNs=; b=iOCxcSTepGu93NwPdV8oocovAJZ7zmuqU3ZYRol79/prqq8/grddALU8IczLPOqErV 78eudCYc/NUvs3NoutIrdDoaG+cq7hGX+VUUTTwWs5mq26+lzXAXHC1/dxYev7iFtMwS f9J1ADydyu51a7iI+7m3ufzDj+g1CyNiaa2QCJMsqVcGzFNhK+lK2vcSC3gw2ItMr5Sh o97DyVjGnHNq1QktyldT6mikmrsj4f7jFoL3wqe7wy8GHuvPtkbHfDIkPsWPiAPJBkpY 4fRslpj99J4EKCK5Lw5WwRCLLwN4ZAoad+yqHEcgjRtxW5NOKzWgqrKNkt9Yu3UoVrhK SDgA== X-Forwarded-Encrypted: i=1; AJvYcCWdsx4mytSuXhv7Dr8SinPh9+Jz3WSMp6CfkH204XTrlHbz6YiFLw7W93YSaWogLBWMSo/assA88PPh@vger.kernel.org X-Gm-Message-State: AOJu0YzovxHFMzv8MRdMlJPF5vpV/yR54KbNfYy9Z6k8dCSrkzv2Mdeg DjTi3zljnSD9sSjuzzzx9gnxqrtf7BPt72Kv0TH8CE9v9/17wWL9917HwET/Uw3A2KBSpxHGIyx JOJzs1tz6o84EKvKj4ya4CksxDmUuFB3X2zgf2g== X-Google-Smtp-Source: AGHT+IF8UjyRnNwMIQwUFBStNL5Otb4CgHfjl+otbh8Bbxjlkxb2dHENFDG1TqcbNMU59Ppougnux5HlFis6uf8hRh4= X-Received: by 2002:a05:6512:3055:b0:530:e323:b1ca with SMTP id 2adb3069b0e04-53565f20df3mr4744502e87.25.1725541981889; Thu, 05 Sep 2024 06:13:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240902-th1520-pinctrl-v1-0-639bf83ef50a@tenstorrent.com> <20240902-th1520-pinctrl-v1-2-639bf83ef50a@tenstorrent.com> In-Reply-To: <20240902-th1520-pinctrl-v1-2-639bf83ef50a@tenstorrent.com> From: Linus Walleij Date: Thu, 5 Sep 2024 15:12:50 +0200 Message-ID: Subject: Re: [PATCH 2/8] pinctrl: Add driver for the T-Head TH1520 SoC To: Drew Fustini Cc: Drew Fustini , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Thomas Bonnefille , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Drew, thanks for your patch! On Tue, Sep 3, 2024 at 6:08=E2=80=AFAM Drew Fustini wrote: > From: Emil Renner Berthing > > Add pinctrl driver for the T-Head TH1520 RISC-V SoC. > > Tested-by: Thomas Bonnefille > Signed-off-by: Emil Renner Berthing > [dfustini: check unit address to identify the pin controller instance] > Signed-off-by: Drew Fustini Overall the patch is in merge quality state, I just want the DT people to tell how we are to handle the groups. I personally would prefer a custom property over the unit name but let's see what they say. Yours, Linus Walleij