linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Li Yang <leoli@freescale.com>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"Gao Pan" <b54642@freescale.com>
Subject: Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional
Date: Mon, 30 Nov 2015 13:55:19 +0100	[thread overview]
Message-ID: <CACRpkdbb-GFJSVvxOLda6CVG_fB2zAPPC2MMzQ6P1mAfvsrkPw@mail.gmail.com> (raw)
In-Reply-To: <1448055950-21190-1-git-send-email-leoli@freescale.com>

On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@freescale.com> wrote:

> -       if (IS_ERR(i2c_imx->pinctrl)) {
> +       /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> +       if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> +                       PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {

This is one of the evils of deferred probe: you never know if
something will eventually turn up. It feels wrong to bail out
on deferred probe...

I have no better idea though.
Acked-by

Yours,
Linus Walleij

  reply	other threads:[~2015-11-30 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 21:45 [PATCH v2] i2c: imx: make bus recovery through pinctrl optional Li Yang
2015-11-30 12:55 ` Linus Walleij [this message]
2016-01-03 18:30   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdbb-GFJSVvxOLda6CVG_fB2zAPPC2MMzQ6P1mAfvsrkPw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=b54642@freescale.com \
    --cc=leoli@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).