From: Linus Walleij <linus.walleij@linaro.org>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Harini Katakam <harinik@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Ezra Savard <ezras@xilinx.com>,
Ezra Savard <ezra.savard@xilinx.com>
Subject: Re: [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation
Date: Thu, 4 Sep 2014 18:27:11 +0200 [thread overview]
Message-ID: <CACRpkdbb0oeA0b5SSLtR6U7jv8asCeEJdHEsDAg7_tH+GHc5RQ@mail.gmail.com> (raw)
In-Reply-To: <1409335127-26712-3-git-send-email-soren.brinkmann@xilinx.com>
On Fri, Aug 29, 2014 at 7:58 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> From: Ezra Savard <ezra.savard@xilinx.com>
>
> Use of unmask/mask in set_wake was an incorrect implementation. The new
> implementation correctly sets wakeup for the gpio chip's IRQ so the gpio chip
> will not sleep while wakeup-enabled gpio are in use.
>
> Signed-off-by: Ezra Savard <ezra.savard@xilinx.com>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Patch applied.
However the problems seems quite generic.
Do you see this kind of error in other GPIO drivers?
IRQchip semantics always make me nervous.
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-09-04 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 17:58 [PATCH 0/3] gpio: zynq: Fix suspend/wake Soren Brinkmann
2014-08-29 17:58 ` [PATCH 1/3] gpio: zynq: Mask non-wakeup GPIO interrupts on suspend Soren Brinkmann
2014-09-04 16:22 ` Linus Walleij
2014-08-29 17:58 ` [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation Soren Brinkmann
2014-09-04 16:27 ` Linus Walleij [this message]
2014-09-04 16:45 ` Sören Brinkmann
2014-08-29 17:58 ` [PATCH 3/3] gpio: lib-sysfs: Add 'wakeup' attribute Soren Brinkmann
2014-09-04 16:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbb0oeA0b5SSLtR6U7jv8asCeEJdHEsDAg7_tH+GHc5RQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=ezra.savard@xilinx.com \
--cc=ezras@xilinx.com \
--cc=gnurou@gmail.com \
--cc=harinik@xilinx.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).