linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>,
	 Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org,  patches@lists.linux.dev
Subject: Re: [PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions()
Date: Mon, 17 Jun 2024 00:37:41 +0200	[thread overview]
Message-ID: <CACRpkdbcCLSUjUaYoUi+mVMBOrcELRe_XExs-zB9417ttPaHVQ@mail.gmail.com> (raw)
In-Reply-To: <20240611-pinctrl-keembay-fix-func-conversion-v1-1-3197f2ded3f7@kernel.org>

On Tue, Jun 11, 2024 at 8:13 PM Nathan Chancellor <nathan@kernel.org> wrote:

> A recent refactoring to use the func member in struct function_desc
> missed converting one uses of name in keembay_build_functions(),
> resulting in a build failure:
>
>   drivers/pinctrl/pinctrl-keembay.c: In function 'keembay_build_functions':
>   drivers/pinctrl/pinctrl-keembay.c:1630:35: error: 'struct function_desc' has no member named 'name'
>    1630 |                         if (!fdesc->name) {
>         |                                   ^~
>
> Perform the same conversion to resolve the build error.
>
> Fixes: 73ee52205e5a ("pinctrl: keembay: Convert to use func member")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

I had cooked my own version of this fix but this came first so I applied this
instead.

Yours,
Linus Walleij

      parent reply	other threads:[~2024-06-16 22:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 18:13 [PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions() Nathan Chancellor
2024-06-11 18:27 ` Andy Shevchenko
2024-06-16 22:37 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdbcCLSUjUaYoUi+mVMBOrcELRe_XExs-zB9417ttPaHVQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=lakshmi.sowjanya.d@intel.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=patches@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).