From: Linus Walleij <linus.walleij@linaro.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 052/182] gpio: pxa: use gpiochip data pointer
Date: Sun, 13 Dec 2015 21:19:49 +0100 [thread overview]
Message-ID: <CACRpkdbdAb4DRWnp_PkxuQpDxaf6O4tY8OMxHd1iWyC-z8J8hg@mail.gmail.com> (raw)
In-Reply-To: <87poyfjnim.fsf@belgarion.home>
On Wed, Dec 9, 2015 at 10:54 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Linus Walleij <linus.walleij@linaro.org> writes:
>
>> This makes the driver use the data pointer added to the gpio_chip
>> to store a pointer to the state container instead of relying on
>> container_of().
>>
>> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
>> Cc: Daniel Mack <zonque@gmail.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> This conflicts with the earlier serie in https://lkml.org/lkml/2015/11/28/136
> which revamps the gpio_chip_base() anyway.
I have already fixed that, I think.
> The patch is perfectly fine, and yet it's the opportunity to ask a review of the
> other serie before other patches make me respin the serie, isn't it ?
I merged it and rebased my patch.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-12-13 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:21 [PATCH 052/182] gpio: pxa: use gpiochip data pointer Linus Walleij
2015-12-09 21:54 ` Robert Jarzmik
2015-12-13 20:19 ` Linus Walleij [this message]
2015-12-13 22:48 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbdAb4DRWnp_PkxuQpDxaf6O4tY8OMxHd1iWyC-z8J8hg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
--cc=robert.jarzmik@free.fr \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).