From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] emev2: GPIOLIB: Enable support for OF Date: Fri, 30 Aug 2013 09:48:38 +0200 Message-ID: References: <1377623069-32678-1-git-send-email-ian.molton@codethink.co.uk> <1377623069-32678-2-git-send-email-ian.molton@codethink.co.uk> <20130830034746.GB17800@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20130830034746.GB17800@verge.net.au> Sender: linux-sh-owner@vger.kernel.org To: Simon Horman Cc: Ian Molton , "linux-gpio@vger.kernel.org" , "linux-sh@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Fri, Aug 30, 2013 at 5:47 AM, Simon Horman wrote: > On Thu, Aug 29, 2013 at 07:41:42PM +0200, Linus Walleij wrote: >> Either the statement needs to be inside #ifdef CONFIG_OF_GPIO >> or the Emma driver need to select OF_GPIO in its Kconfig >> entry. > > This may be somewhat naieve, but it seems to me that the latter would be a > better choice at this stage because AFIK the only in-tree emev2 board is > the kzm9d and it uses USE_OF. I think you're right. Ian can you cook a patch that also selects OF_GPIO for this controller in Kconfig? Yours, Linus Walleij