From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio: omap: prevent module from being unloaded while in use Date: Thu, 16 Jul 2015 14:27:17 +0200 Message-ID: References: <1435245213-17858-1-git-send-email-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f41.google.com ([209.85.218.41]:36289 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbbGPM1R (ORCPT ); Thu, 16 Jul 2015 08:27:17 -0400 Received: by oibn4 with SMTP id n4so49071319oib.3 for ; Thu, 16 Jul 2015 05:27:17 -0700 (PDT) In-Reply-To: <1435245213-17858-1-git-send-email-grygorii.strashko@ti.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Grygorii Strashko Cc: Alexandre Courbot , Tony Lindgren , Sekhar Nori , Santosh Shilimkar , Javier Martinez Canillas , Linux-OMAP , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Thu, Jun 25, 2015 at 5:13 PM, Grygorii Strashko wrote: > OMAP GPIO driver allowed to be built as loadable module, but it > doesn't set owner field in GPIO chip structure. As result, > module_get/put() API is not working and it's possible to unload > OMAP driver while in use: > > omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED > > Hence, add missing configuration. > > Cc: Tony Lindgren > Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module') > Signed-off-by: Grygorii Strashko > --- > Hi Linus, > > Seems this one is for 4.2-rc. Yup applied for fixes with Alex' ACK. The bigger fix is applied for devel and the best way to handle this is open for discussion. Yours, Linus Walleij