From: Linus Walleij <linus.walleij@linaro.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Frank Rowand <frowand.list@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 3/4] gpiolib: acpi: support bias pull disable
Date: Mon, 18 Jul 2022 12:32:29 +0200 [thread overview]
Message-ID: <CACRpkdbitDErSCMbKFe0yZB63+uTGwt5ROMbEV_iAPck_RN7sg@mail.gmail.com> (raw)
In-Reply-To: <20220713131421.1527179-4-nuno.sa@analog.com>
On Wed, Jul 13, 2022 at 3:13 PM Nuno Sá <nuno.sa@analog.com> wrote:
> On top of looking at PULL_UP and PULL_DOWN flags, also look at
> PULL_DISABLE and set the appropriate GPIO flag. The GPIO core will then
> pass down this to controllers that support it.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Do we have a semantic check that PULLDOWN and PULLUP
is not used in combination with NOPULL here?
(We should also be checking that PULLDOWN and PULLUP
are not used simultaneously but that is an unrelated thing.)
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-07-18 10:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:14 [PATCH 0/4] add support for bias pull-disable Nuno Sá
2022-07-13 13:14 ` [PATCH 1/4] gpiolib: add support for bias pull disable Nuno Sá
2022-07-13 17:36 ` Andy Shevchenko
2022-07-14 4:20 ` Kent Gibson
2022-07-14 7:14 ` Nuno Sá
2022-07-14 8:27 ` Kent Gibson
2022-07-14 8:47 ` Nuno Sá
2022-07-14 12:00 ` Kent Gibson
2022-07-14 13:02 ` Nuno Sá
2022-07-14 15:08 ` Andy Shevchenko
2022-07-14 15:47 ` Nuno Sá
2022-07-18 10:44 ` Linus Walleij
2022-07-13 13:14 ` [PATCH 2/4] gpiolib: of: support " Nuno Sá
2022-07-18 10:30 ` Linus Walleij
2022-07-13 13:14 ` [PATCH 3/4] gpiolib: acpi: " Nuno Sá
2022-07-18 10:32 ` Linus Walleij [this message]
2022-07-18 10:49 ` Nuno Sá
2022-07-18 13:49 ` Linus Walleij
2022-07-18 18:25 ` Andy Shevchenko
2022-07-13 13:14 ` [PATCH 4/4] dt-bindings: gpio: add pull-disable flag Nuno Sá
2022-07-18 10:33 ` Linus Walleij
2022-07-18 20:52 ` Rob Herring
2022-07-13 17:39 ` [PATCH 0/4] add support for bias pull-disable Andy Shevchenko
2022-07-14 7:09 ` Nuno Sá
2022-07-14 9:12 ` Andy Shevchenko
2022-07-14 9:49 ` Nuno Sá
2022-07-14 14:58 ` Andy Shevchenko
2022-07-14 15:43 ` Nuno Sá
2022-07-14 18:57 ` Andy Shevchenko
2022-07-15 10:20 ` Nuno Sá
2022-07-15 12:05 ` Andy Shevchenko
2022-07-15 12:20 ` Nuno Sá
2022-07-15 19:31 ` Bartosz Golaszewski
2022-07-18 7:51 ` Nuno Sá
2022-07-18 10:29 ` Linus Walleij
2022-07-18 10:46 ` Nuno Sá
2022-07-18 10:25 ` Linus Walleij
2022-07-19 8:25 ` Bartosz Golaszewski
2022-07-19 8:52 ` Nuno Sá
2022-07-19 9:14 ` Bartosz Golaszewski
2022-07-19 10:21 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbitDErSCMbKFe0yZB63+uTGwt5ROMbEV_iAPck_RN7sg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).