From: Linus Walleij <linus.walleij@linaro.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Vladimir Murzin <vladimir.murzin@arm.com>
Subject: Re: [PATCH] gpio: syscon: do not use raw "set" callback in syscon_gpio_dir_out
Date: Fri, 22 Sep 2017 15:42:52 +0200 [thread overview]
Message-ID: <CACRpkdbj072oeH3nQWyski7spgfeeuYsvTOiiZiUQtArNVKh5Q@mail.gmail.com> (raw)
In-Reply-To: <1505994978.366886647@f249.i.mail.ru>
On Thu, Sep 21, 2017 at 1:56 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>>Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij <linus.walleij@linaro.org>:
>>
>>I really need Alexander Shiyan to look at this patch.
>>
>>The way i percieve it, .set is NULL if the chip does not
>>support output.
>>
>>We should print the right error messages and bail out
>>if the user is anyway trying to set a line like that.
>
> Hello.
>
> Using "chip->set", instead of "priv->data->set", is more proper way on my opinion.
> However, if the driver is not configured for output, the any errors should not occur in any case.
Is that an Acked-by?
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-09-22 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 14:50 [PATCH] gpio: syscon: do not use raw "set" callback in syscon_gpio_dir_out Vladimir Murzin
2017-09-21 11:23 ` Linus Walleij
2017-09-21 11:56 ` Alexander Shiyan
2017-09-22 10:23 ` Vladimir Murzin
2017-09-22 13:47 ` Linus Walleij
2017-09-22 14:12 ` Vladimir Murzin
2017-09-22 13:42 ` Linus Walleij [this message]
2017-09-25 5:21 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbj072oeH3nQWyski7spgfeeuYsvTOiiZiUQtArNVKh5Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-gpio@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).