From: Linus Walleij <linus.walleij@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel-janitors@vger.kernel.org,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put
Date: Tue, 22 Dec 2015 13:47:21 +0100 [thread overview]
Message-ID: <CACRpkdbmG8h31EFJMHFC2nx3vp4_G2ZR-wvOmioF5eh5YmVn7w@mail.gmail.com> (raw)
In-Reply-To: <1450715988-4770-4-git-send-email-Julia.Lawall@lip6.fr>
On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so a
> goto out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
Patch applied with Laurent's ACK.
Geert: since I don't think you're gonna send me more pull
requests before the merge window I went ahead and applied
this directly, OK?
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-12-22 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 16:39 [PATCH 0/5] add missing of_node_put Julia Lawall
2015-12-21 16:39 ` [PATCH 1/5] pinctrl-tegra: " Julia Lawall
2015-12-22 12:44 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 2/5] pinctrl: sirf: " Julia Lawall
2015-12-22 12:45 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 3/5] pinctrl: sh-pfc: " Julia Lawall
2015-12-21 20:46 ` Laurent Pinchart
2015-12-22 12:47 ` Linus Walleij [this message]
2015-12-22 13:23 ` Geert Uytterhoeven
2015-12-21 16:39 ` [PATCH 4/5] pinctrl: rockchip: " Julia Lawall
[not found] ` <1450715988-4770-5-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2015-12-21 21:20 ` Heiko Stübner
2015-12-22 12:48 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 5/5] pinctrl: mediatek: " Julia Lawall
2015-12-22 12:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbmG8h31EFJMHFC2nx3vp4_G2ZR-wvOmioF5eh5YmVn7w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Julia.Lawall@lip6.fr \
--cc=geert+renesas@glider.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).