From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v4] gpio: pcf857x: Add OF support Date: Fri, 30 Aug 2013 10:07:23 +0200 Message-ID: References: <1377524753-4027-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <32047086.JjfkHtWF69@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-oa0-f42.google.com ([209.85.219.42]:52549 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453Ab3H3IHY (ORCPT ); Fri, 30 Aug 2013 04:07:24 -0400 Received: by mail-oa0-f42.google.com with SMTP id j10so1494910oah.1 for ; Fri, 30 Aug 2013 01:07:24 -0700 (PDT) In-Reply-To: <32047086.JjfkHtWF69@avalon> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Laurent Pinchart Cc: Laurent Pinchart , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Tomasz Figa , Sylwester Nawrocki , Alexandre Courbot On Fri, Aug 30, 2013 at 2:05 AM, Laurent Pinchart wrote: > On Thursday 29 August 2013 14:16:59 Linus Walleij wrote: >> On Mon, Aug 26, 2013 at 3:45 PM, Laurent Pinchart wrote: >> Don't we want to do this generic if we shall do it? >> >> Like for *any* GPIO chips we provide lines-initial state in the device >> tree and some code in the gpiochip with a callback in struct gpio_chip >> that can be called by the gpiolib core to set this up? Then we don't >> have to reimplement this for every GPIO controller that needs it. > > Most GPIO chips will provide a way to read back the current state. The initial > state only needs to be provided for write-only chips. This is (luckily) rather > an exception, so I don't think we should implement it in the core, at least > not yet. We can always refactor the code later if needed, the proposed DT > binding is generic enough. But I think this can be useful on any GPIO chip. For someone deploying some system and hacking around in the device tree to set the GPIOs up properly at boot it can be a real useful tool. Or is that giving them too much rope? :-D Yours, Linus Walleij