From: Linus Walleij <linus.walleij@linaro.org>
To: Light Hsieh <light.hsieh@mediatek.com>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sean Wang <sean.wang@kernel.org>
Subject: Re: [PATCH v1 5/5] pinctrl: mediatek: Add support for pin configuration dump via sysfs.
Date: Fri, 23 Aug 2019 09:52:37 +0200 [thread overview]
Message-ID: <CACRpkdbpsK08mYX_M5vvaExR2HCa8ct16zC92euLJzewYEDG-Q@mail.gmail.com> (raw)
In-Reply-To: <1565686400-5711-6-git-send-email-light.hsieh@mediatek.com>
Hi Light,
thanks for your patch!
On Tue, Aug 13, 2019 at 10:53 AM Light Hsieh <light.hsieh@mediatek.com> wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Add support for pin configuration dump via catting
> /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins.
This is debugfs so rename the subject "*debugfs"
> pinctrl framework had already support such dump. This patch implement the
> operation function pointer to fullfill this dump.
Fair enough, that's fine.
> Change-Id: Ib59212eb47febcd84140cbf84e1bd7286769beb0
This has been remarked on before.
This patch is missing your Signed-off-by, please fix that.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-08-23 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 8:53 [PATCH v1 0/5] Improve MediaTek pinctrl v2 and make backward compatible to smartphone mass production usage Light Hsieh
2019-08-13 8:53 ` [PATCH v1 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup() Light Hsieh
2019-08-13 22:54 ` Sean Wang
2019-08-13 8:53 ` [PATCH v1 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value Light Hsieh
2019-08-14 0:08 ` Sean Wang
2019-08-13 8:53 ` [PATCH v1 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set() Light Hsieh
2019-08-13 8:53 ` [PATCH v1 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage Light Hsieh
2019-08-13 23:24 ` Sean Wang
2019-08-13 8:53 ` [PATCH v1 5/5] pinctrl: mediatek: Add support for pin configuration dump via sysfs Light Hsieh
2019-08-23 7:52 ` Linus Walleij [this message]
2019-08-23 7:50 ` [PATCH v1 0/5] Improve MediaTek pinctrl v2 and make backward compatible to smartphone mass production usage Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbpsK08mYX_M5vvaExR2HCa8ct16zC92euLJzewYEDG-Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=light.hsieh@mediatek.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).