From: Linus Walleij <linus.walleij@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: baytrail: Do not call WARN_ON for a firmware bug
Date: Tue, 1 Aug 2017 15:19:09 +0200 [thread overview]
Message-ID: <CACRpkdbqHVkksJuu2ibRxOitjdMQyXuNi3njAf4zgamYhr72Qw@mail.gmail.com> (raw)
In-Reply-To: <20170712123101.26996-1-hdegoede@redhat.com>
On Wed, Jul 12, 2017 at 2:31 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> WARN_ON causes a backtrace to get logged which is only useful for
> kernel bugs. For signalling a firmware bug dev_warn(dev, FW_BUG "...")
> should be used.
>
> This fixes users running userspace software to monitor kernel oopses
> getting a false positive bug-report every boot because of the wrong
> use of WARN_ON.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Patch applied with Andy's ACK.
Yours,
Linus Walleij
prev parent reply other threads:[~2017-08-01 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 12:31 [PATCH] pinctrl: baytrail: Do not call WARN_ON for a firmware bug Hans de Goede
2017-07-12 12:38 ` Andy Shevchenko
2017-07-12 12:44 ` Hans de Goede
2017-07-12 13:12 ` Andy Shevchenko
2017-07-12 14:18 ` Hans de Goede
2017-07-12 15:25 ` Andy Shevchenko
2017-08-01 13:19 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbqHVkksJuu2ibRxOitjdMQyXuNi3njAf4zgamYhr72Qw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).