* [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call
@ 2022-09-23 10:10 Shang XiaoJing
2022-09-23 22:57 ` Florian Fainelli
2022-10-04 7:24 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Shang XiaoJing @ 2022-09-23 10:10 UTC (permalink / raw)
To: rjui, sbranden, bcm-kernel-feedback-list, linus.walleij,
linux-gpio
Cc: shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
drivers/pinctrl/bcm/pinctrl-ns.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-ns.c b/drivers/pinctrl/bcm/pinctrl-ns.c
index 65a86543c58c..465cc96814a1 100644
--- a/drivers/pinctrl/bcm/pinctrl-ns.c
+++ b/drivers/pinctrl/bcm/pinctrl-ns.c
@@ -233,10 +233,8 @@ static int ns_pinctrl_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"cru_gpio_control");
ns_pinctrl->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(ns_pinctrl->base)) {
- dev_err(dev, "Failed to map pinctrl regs\n");
+ if (IS_ERR(ns_pinctrl->base))
return PTR_ERR(ns_pinctrl->base);
- }
memcpy(pctldesc, &ns_pinctrl_desc, sizeof(*pctldesc));
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call
2022-09-23 10:10 [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-23 22:57 ` Florian Fainelli
2022-10-04 7:24 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-09-23 22:57 UTC (permalink / raw)
To: Shang XiaoJing, rjui, sbranden, bcm-kernel-feedback-list,
linus.walleij, linux-gpio
On 9/23/22 03:10, 'Shang XiaoJing' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call
2022-09-23 10:10 [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call Shang XiaoJing
2022-09-23 22:57 ` Florian Fainelli
@ 2022-10-04 7:24 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-10-04 7:24 UTC (permalink / raw)
To: Shang XiaoJing; +Cc: rjui, sbranden, bcm-kernel-feedback-list, linux-gpio
On Fri, Sep 23, 2022 at 11:37 AM Shang XiaoJing
<shangxiaojing@huawei.com> wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 7:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-23 10:10 [PATCH -next] pinctrl: bcm: ns: Remove redundant dev_err call Shang XiaoJing
2022-09-23 22:57 ` Florian Fainelli
2022-10-04 7:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).