From: Linus Walleij <linus.walleij@linaro.org>
To: Peter Rosin <peda@axentia.se>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] pinctrl: sx150x: handle missing 'advanced' reg in sx1504 and sx1505
Date: Fri, 2 Dec 2016 14:02:34 +0100 [thread overview]
Message-ID: <CACRpkdbsSLKK+McCUm+O+gDozPzVzF5pjUL9iRFexk1vGuUMUA@mail.gmail.com> (raw)
In-Reply-To: <1480675876-19540-4-git-send-email-peda@axentia.se>
On Fri, Dec 2, 2016 at 11:51 AM, Peter Rosin <peda@axentia.se> wrote:
> This fixes a problem where sx150x_regmap_reg_width() returns 8 for the
> data register (reg 0) for sx1504 where it should return 4, and return
> a correct 8 for sx1505 but for the wrong reason (both chips lack the
> 'advanced' register). This is not a real problem, since nothing depends
> on the function returning 4 or 8, and certainly not if it is returning
> 8 for the wrong reason. But fix this to avoid nasty surprises down the
> line.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Patch applied.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-12-02 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 10:51 [PATCH 0/3] pinctrl: sx150x fixes for the 4-pin chips Peter Rosin
2016-12-02 10:51 ` [PATCH 1/3] pinctrl: sx150x: access the correct bits in the 4-bit regs of sx150[147] Peter Rosin
2016-12-02 13:00 ` Linus Walleij
2016-12-02 10:51 ` [PATCH 2/3] pinctrl: sx150x: rename 'reg_advance' to 'reg_advanced' Peter Rosin
2016-12-02 13:01 ` Linus Walleij
2016-12-02 10:51 ` [PATCH 3/3] pinctrl: sx150x: handle missing 'advanced' reg in sx1504 and sx1505 Peter Rosin
2016-12-02 13:02 ` Linus Walleij [this message]
2016-12-02 10:56 ` [PATCH 0/3] pinctrl: sx150x fixes for the 4-pin chips Peter Rosin
2016-12-02 13:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbsSLKK+McCUm+O+gDozPzVzF5pjUL9iRFexk1vGuUMUA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).