From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFDEC433FE for ; Mon, 20 Dec 2021 20:42:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbhLTUmC (ORCPT ); Mon, 20 Dec 2021 15:42:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbhLTUmB (ORCPT ); Mon, 20 Dec 2021 15:42:01 -0500 Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272ACC061574; Mon, 20 Dec 2021 12:42:01 -0800 (PST) Received: by mail-oo1-xc2b.google.com with SMTP id g11-20020a4a754b000000b002c679a02b18so3427437oof.3; Mon, 20 Dec 2021 12:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gRvhlXLq7L2YbTCbc1T1kLAsYxro2S3SeoZnogVM8pY=; b=ZvD1Th8rpbQRSrioTCscGQZd7Z2rdh/FlGxKSl8P5IBz/+JlSMyMV86iRVOlEP5Gaj WKWq1WVjhYCAZToQLKIsWSgUcFj0Tb4aijNJ2lClVU6RNeaQjcZgDhn/jZsUalgBZoh5 WkVYMFUFkrRgbP+lkn//4bL4NK+yH1UuRieGk+o2do/xdf5ppW/WAwYUfS1jp0L5A60c jSngayaVl4dBuaJZDq56gbUSpmCMKWrNQHut7LV+0KQcT14/twBxY8CYBxGgXQGFL4Fo o5rlqr6Mt3cHqyKtDWbtzmklk6OG4R6i+cf/P9Zx6i2P9TDxzgoq0aXcxU3z1xkUg2pT NYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gRvhlXLq7L2YbTCbc1T1kLAsYxro2S3SeoZnogVM8pY=; b=HM5/F7gfOEIWYNgPjEWXvy6oXx1a3HPFAooQaDand5PMvggQSTpL6j7XTE3e1jO8R4 lLpZM0Z4vFsi9YmliFQDULcoUf+xOhl9I+TqFsDmNcmC/tfDfO4X+J/j/Szojzbnn89L u8RdBuklgJT9/hvpwWLrpw0rkfoS9fryvfGhGT1IuCOeEZ1dlHcB7+e28Fpfi4MZrO7V xprUCHedY6QzuKso8zRaz8X/vNUvUtZk5dQmUfYDzk5T+0/Fi9Bvzx2TwhtSWUPPyCPO LZN9dDeMP0VKTDseZcf6KsU0mMSeSKirF2FyPLv5yMZLf+7r3oSKZakaSOlgDd++8N31 nTpw== X-Gm-Message-State: AOAM530JlnfQArisx7DoOE3Zo2xgbZQspkZH0FE0XbIUepslB0IT0bd1 2YbLnoZg68Uj0LN7x2hgM1DAnNk0upkwRMkWxpo= X-Google-Smtp-Source: ABdhPJy1MZs4O+yyJBNYKMLmmBoVIsXRs8uqhfPBXDSfWex6X7qLQ7uu2VtlPx2eCyvlficUTrBR3AAGoUG9iNqDV8M= X-Received: by 2002:a4a:3511:: with SMTP id l17mr11541366ooa.74.1640032920411; Mon, 20 Dec 2021 12:42:00 -0800 (PST) MIME-Version: 1.0 References: <20211217153555.9413-1-marcelo.jimenez@gmail.com> In-Reply-To: From: Marcelo Roberto Jimenez Date: Mon, 20 Dec 2021 17:41:34 -0300 Message-ID: Subject: Re: [PATCH] gpio: Revert regression in sysfs-gpio (gpiolib.c) To: Geert Uytterhoeven Cc: Bartosz Golaszewski , Thorsten Leemhuis , stable , regressions@lists.linux.dev, Linus Walleij , "open list:GPIO SUBSYSTEM" , Thierry Reding , Vidya Sagar , Stephen Rothwell , Edmond Chung , Andrew Chant , Will McVicker , Sergio Tanzilli Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Geert, On Mon, Dec 20, 2021 at 12:14 PM Geert Uytterhoeven wrote: > > On Mon, Dec 20, 2021 at 3:57 PM Bartosz Golaszewski wrote: > > On Sat, Dec 18, 2021 at 7:28 AM Thorsten Leemhuis > > wrote: > > > [TLDR: I'm adding this regression to regzbot, the Linux kernel > > > regression tracking bot; most text you find below is compiled from a few > > > templates paragraphs some of you might have seen already.] > > > > > > On 17.12.21 16:35, Marcelo Roberto Jimenez wrote: > > > > Some GPIO lines have stopped working after the patch > > > > commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") > > > > > > > > And this has supposedly been fixed in the following patches > > > > commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") > > > > commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") > > > > > > There seems to be a backstory here. Are there any entries and bug > > > trackers or earlier discussions everyone that looks into this should be > > > aware of? > > > > > > > Agreed with Thorsten. I'd like to first try to determine what's wrong > > before reverting those, as they are correct in theory but maybe the > > implementation missed something. > > > > Have you tried tracing the execution on your platform in order to see > > what the driver is doing? > > Looking at commits that have related Fixes tags: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bf781869e5cf3e4ec1a47dad69b6f0df97629cbd > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?id=e8f24c58d1b69ecf410a673c22f546dc732bb879 > Interesting. These seem to imply that gpiolib-sysfs.c should be allocating a pinctrl list. That seems very easy to do in the DTD, although I don't really know if that is the right thing to do. Doing it in the code seems more appropriate, what do you think? > Gr{oetje,eeting}s, > > Geert Regards, Marcelo.