From: "Kornel Dulęba" <korneld@chromium.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
upstream@semihalf.com, rad@semihalf.com, mattedavis@google.com
Subject: Re: [PATCH] pinctrl: amd: Disable and mask interrupts on resume
Date: Mon, 20 Mar 2023 12:07:31 +0100 [thread overview]
Message-ID: <CAD=Nsqwc2YwoEvvAFJd-QBKsP75vjqbCcAjB=k2s5=oYL7AtgA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbhV1qE+Kx4cqAKiv4Zacv6tQ8wKF8C6+0kZ-Dw=0cx7Q@mail.gmail.com>
On Mon, Mar 20, 2023 at 11:05 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Mar 20, 2023 at 10:33 AM Kornel Dulęba <korneld@chromium.org> wrote:
>
> > This fixes a similar problem to the one observed in:
> > commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe").
> >
> > On some systems, during suspend/resume cycle firmware leaves
> > an interrupt enabled on a pin that is not used by the kernel.
> > This confuses the AMD pinctrl driver and causes spurious interrupts.
> >
> > The driver already has logic to detect if a pin is used by the kernel.
> > Leverage it to re-initialize interrupt fields of a pin only if it's not
> > used by us.
> >
> > Signed-off-by: Kornel Dulęba <korneld@chromium.org>
>
> Uh oh this looks serious.
> Do we need a Fixes: tag and Cc: stable on this patch?
I suppose so.
I didn't add them since I'm not sure what commit Fixes: should point to.
This issue seems to have always been there, so probably the first
commit of this driver?
Regards
Kornel Dulęba
next prev parent reply other threads:[~2023-03-20 11:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:32 [PATCH] pinctrl: amd: Disable and mask interrupts on resume Kornel Dulęba
2023-03-20 10:05 ` Linus Walleij
2023-03-20 11:07 ` Kornel Dulęba [this message]
2023-03-28 13:20 ` Linus Walleij
2023-04-10 5:03 ` Mario Limonciello
2023-04-10 15:29 ` Gong, Richard
2023-04-10 16:17 ` Kornel Dulęba
2023-04-10 16:32 ` Kornel Dulęba
2023-04-11 1:29 ` Mario Limonciello
2023-04-11 12:50 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-11 13:09 ` Kornel Dulęba
2023-04-11 13:29 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-11 13:35 ` Kornel Dulęba
2023-04-11 13:43 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-11 20:44 ` Linus Walleij
2023-04-12 10:47 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-11 13:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=Nsqwc2YwoEvvAFJd-QBKsP75vjqbCcAjB=k2s5=oYL7AtgA@mail.gmail.com' \
--to=korneld@chromium.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattedavis@google.com \
--cc=rad@semihalf.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).