From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791B3C6FD1D for ; Mon, 20 Mar 2023 11:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbjCTLLp (ORCPT ); Mon, 20 Mar 2023 07:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjCTLLT (ORCPT ); Mon, 20 Mar 2023 07:11:19 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B17283E1 for ; Mon, 20 Mar 2023 04:07:43 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id bm1so3499218qkb.13 for ; Mon, 20 Mar 2023 04:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679310462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1nhhh3ZAx0xZch5t5NtSJYd3fI/Bc023/J/5SBijWjM=; b=UWb/p11JlyjTRspUh9LLV29UvG4RRfmZMQkZt/vWq+FGLIsHlgyjrZ/2Cgn+yxNOgX 3KdcFXpbnZfOZJwbiD4r1J/zESQRvrAQS/ZLxvPYc/QXiWazfYeSuMxXHq83I5ykTwZp rTk0AeQUy6RZtagfmPEuLkUOUNQXvsyxeACws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679310462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1nhhh3ZAx0xZch5t5NtSJYd3fI/Bc023/J/5SBijWjM=; b=nWCLLX6Nkgfu8+moigX9f7LiFlyb94SzL2fC1Pwk74oiG37DQWa8X4oKW2ACXekxZf 60QlM2Bze9N3OpHfetju8IUjvJ0jLFeHhHyGRj4Cydw4edbSi82Lzd+Xz/+jc8CMKHvZ chXGgycE8UefttQY12MhaG6zHWuOOKe0IoluOzuRLQC0spSf9+weDxDRC9f2RFom3NGc SxFqtjBf7pxDKuxf/DAm81EFSlSR9GFHj0isGg2Qunkz2NkM6MWvkviQeJ8jYpAEY8be Cgzss/booNBH6DH+5iUOGs+gcq3KbpKZD2qRhTCZGTe6bxWZ4+0DID7XhNUPyokEIP5O N+pg== X-Gm-Message-State: AO0yUKUliyXfqajphgnPo2wTlFypx3PFlA17uhw1Um8ieq+tAoxDb1L8 4IJkGA/mKuVlXGF9IYLjadhe9bfVYlaYx2JcYwpuug== X-Google-Smtp-Source: AK7set8cb9/s4D03g/8LJ0LA4+vl/0316AdPNeF6DMM8RwcazkcFYHdLNsSwoFGJC+C2MkiQGnQpuJ8FObIZiCkQPPc= X-Received: by 2002:a05:620a:b44:b0:746:9174:3d3c with SMTP id x4-20020a05620a0b4400b0074691743d3cmr159611qkg.13.1679310461788; Mon, 20 Mar 2023 04:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20230320093259.845178-1-korneld@chromium.org> In-Reply-To: From: =?UTF-8?Q?Kornel_Dul=C4=99ba?= Date: Mon, 20 Mar 2023 12:07:31 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: amd: Disable and mask interrupts on resume To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Basavaraj Natikar , Shyam Sundar S K , upstream@semihalf.com, rad@semihalf.com, mattedavis@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 20, 2023 at 11:05=E2=80=AFAM Linus Walleij wrote: > > On Mon, Mar 20, 2023 at 10:33=E2=80=AFAM Kornel Dul=C4=99ba wrote: > > > This fixes a similar problem to the one observed in: > > commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on prob= e"). > > > > On some systems, during suspend/resume cycle firmware leaves > > an interrupt enabled on a pin that is not used by the kernel. > > This confuses the AMD pinctrl driver and causes spurious interrupts. > > > > The driver already has logic to detect if a pin is used by the kernel. > > Leverage it to re-initialize interrupt fields of a pin only if it's not > > used by us. > > > > Signed-off-by: Kornel Dul=C4=99ba > > Uh oh this looks serious. > Do we need a Fixes: tag and Cc: stable on this patch? I suppose so. I didn't add them since I'm not sure what commit Fixes: should point to. This issue seems to have always been there, so probably the first commit of this driver? Regards Kornel Dul=C4=99ba