* [PATCH 03/45] drivers: gpio: remove duplicate includes
@ 2017-12-05 1:58 Pravin Shedge
2017-12-06 22:29 ` Gregory Fong
0 siblings, 1 reply; 2+ messages in thread
From: Pravin Shedge @ 2017-12-05 1:58 UTC (permalink / raw)
Cc: pravin.shedge4linux, Gregory Fong, Linus Walleij, Brian Norris,
Florian Fainelli, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, linux-kernel
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
drivers/gpio/gpio-brcmstb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 545d43a..f40ec39 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -11,7 +11,6 @@
* GNU General Public License for more details.
*/
-#include <linux/bitops.h>
#include <linux/gpio/driver.h>
#include <linux/of_device.h>
#include <linux/of_irq.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 03/45] drivers: gpio: remove duplicate includes
2017-12-05 1:58 [PATCH 03/45] drivers: gpio: remove duplicate includes Pravin Shedge
@ 2017-12-06 22:29 ` Gregory Fong
0 siblings, 0 replies; 2+ messages in thread
From: Gregory Fong @ 2017-12-06 22:29 UTC (permalink / raw)
To: Pravin Shedge
Cc: Linus Walleij, Brian Norris, Florian Fainelli,
bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Pravin,
On Mon, Dec 4, 2017 at 5:58 PM, Pravin Shedge
<pravin.shedge4linux@gmail.com> wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index 545d43a..f40ec39 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -11,7 +11,6 @@
> * GNU General Public License for more details.
> */
>
> -#include <linux/bitops.h>
Please remove the second entry at the end of the include list instead
of this one, since that is the duplicate added accidentally in
d74423687f9d70417bfec68121cbd35f79bb170f "gpio: brcmstb: Do not use
gc->pin2mask()" [1].
> #include <linux/gpio/driver.h>
> #include <linux/of_device.h>
> #include <linux/of_irq.h>
Thanks,
Gregory
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpio-brcmstb.c?id=d74423687f9d70417bfec68121cbd35f79bb170f
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-06 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 1:58 [PATCH 03/45] drivers: gpio: remove duplicate includes Pravin Shedge
2017-12-06 22:29 ` Gregory Fong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).