From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Fong Subject: Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks Date: Fri, 31 Aug 2018 14:26:01 -0700 Message-ID: References: <1534549659-15883-1-git-send-email-justinpopo6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1534549659-15883-1-git-send-email-justinpopo6@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Justin Chen Cc: linux-gpio@vger.kernel.org, Linus Walleij , Brian Norris , Florian Fainelli , bcm-kernel-feedback-list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Fri, Aug 17, 2018 at 4:48 PM wrote: > > From: Justin Chen > > Sometimes we have empty banks within the GPIO block. This commit allows > proper handling of 0 width GPIO banks. We handle 0 width GPIO banks by > incrementing the bank and number of GPIOs, but not initializing them. > This will mean a call into the non-existent GPIOs will return an error. This is clearer now; thanks for rewording! > > Also remove "GPIO registered" dev print. This information is misleading > since the incremented banks and gpio_base do not reflect the actual GPIOs > that get initialized. We leave this information out since it is already > printed with dev_dbg. > > Signed-off-by: Justin Chen Looks like I'm a bit late on the response, but in case you feel like adding it Linus: Acked-by: Gregory Fong