From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: Re: [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins Date: Sun, 4 Sep 2016 19:55:55 +0200 Message-ID: References: <20160828164725.19429-1-martin.blumenstingl@googlemail.com> <20160828164725.19429-3-martin.blumenstingl@googlemail.com> <20160828191353.wpwbqsxdg5pdmese@vip.cybercity.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:33411 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbcIDR4R (ORCPT ); Sun, 4 Sep 2016 13:56:17 -0400 Received: by mail-wm0-f68.google.com with SMTP id w207so10087318wmw.0 for ; Sun, 04 Sep 2016 10:56:17 -0700 (PDT) In-Reply-To: <20160828191353.wpwbqsxdg5pdmese@vip.cybercity.dk> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Rask Ingemann Lambertsen , Rob Herring Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linus.walleij@linaro.org, khilman@baylibre.com, carlo@caione.org, linux-arm-kernel@lists.infradead.org On Sun, Aug 28, 2016 at 9:13 PM, Rask Ingemann Lambertsen wrote: > On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: >> uart_a_pins: uart_a { >> mux { >> groups = "uart_tx_a", > > You shouldn't use underscores in node names. Use hyphens instead, perhaps. > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html The part which you found there is just the context of my patch, not an actual change. However, basically all of the GXBB .dts files are using underscores in the node names. Do "we" have to change this globally? Regarding my patch: I got a NACK from Neil Armstrong off-list: The SDIO IRQ pin is missing in my series. Regards, Martin