From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Qianggui Song <qianggui.song@amlogic.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] pinctrl: meson: add pinctrl driver support for Meson-S4 Soc
Date: Thu, 30 Dec 2021 23:09:02 +0100 [thread overview]
Message-ID: <CAFBinCDPtiPHZ7BkTLoqpd1HiNQa1n45MeByzGHtHmK=-oOxzQ@mail.gmail.com> (raw)
In-Reply-To: <20211229121605.10513-4-qianggui.song@amlogic.com>
On Wed, Dec 29, 2021 at 1:16 PM Qianggui Song <qianggui.song@amlogic.com> wrote:
>
> Add new pinctrl driver for Amlogic's Meson-S4 SoC which share the
> same register layout as the previous Meson-A1.
>
> Signed-off-by: Qianggui Song <qianggui.song@amlogic.com>
Due to lack of a datasheet to compare this with I cannot properly review this.
Instead I confirm that this generally looks good apart from two very
small nit-picks:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
I suggest waiting for Jerome's review before re-sending this series.
[...]
> +static const char * const mclk_1_groups[] = {
> + "mclk_1_c", "mclk_1_d", "mclk_1_h", "mclk_2",
> +
There's an extraneous empty line here.
[...[
> +static const char * const pwm_b_groups[] = {
> + "pwm_b_d", "pwm_b_x",
> +
There's an extraneous empty line here.
Best regards,
Martin
prev parent reply other threads:[~2021-12-30 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 12:16 [PATCH v3 0/3] pinctrl: meson-s4: add pinctrl driver Qianggui Song
2021-12-29 12:16 ` [PATCH v3 1/3] dt-bindings: pinctrl: meson: Add compatible for S4 Qianggui Song
2021-12-30 22:02 ` Martin Blumenstingl
2021-12-29 12:16 ` [PATCH v3 2/3] dt-bindings: gpio: Add a header file for Amlogic Meson S4 Qianggui Song
2021-12-30 22:02 ` Martin Blumenstingl
2021-12-29 12:16 ` [PATCH v3 3/3] pinctrl: meson: add pinctrl driver support for Meson-S4 Soc Qianggui Song
2021-12-30 22:09 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCDPtiPHZ7BkTLoqpd1HiNQa1n45MeByzGHtHmK=-oOxzQ@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=qianggui.song@amlogic.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).