Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c

Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c

[Otto Meier]

Hi i tried to use the uart_C of the the odroid-c2.

I enabled it in the dts file. During boot it crashed when the
the sdcard slot is addressed.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856

After changing the pin definitions accordingly erverything works.
Uart_c is functioning and sdcard ist working.


Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
Signed-off-by: Otto Meiergf435@gmx.net
---


--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-08-26 
18:24:45.450089334 +0200
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-09-05 
13:07:38.518637214 +0200
@@ -192,8 +192,8 @@  static const unsigned int uart_rts_b_pin
  
  static const unsigned int uart_tx_c_pins[]     = { GPIOY_13 };
  static const unsigned int uart_rx_c_pins[]     = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
  
  static const unsigned int i2c_sck_a_pins[]     = { GPIODV_25 };
  static const unsigned int i2c_sda_a_pins[]     = { GPIODV_24 };
@@ -439,10 +439,10 @@  static struct meson_pmx_group meson_gxbb
         GROUP(pwm_f_x,          3,      18),
  
         /* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
         GROUP(pwm_a_y,          1,      21),
         GROUP(pwm_f_y,          1,      20),
         GROUP(i2s_out_ch23_y,   1,      5),

Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c

[Linus Walleij]

On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:

> Hi i tried to use the uart_C of the the odroid-c2.
>
> I enabled it in the dts file. During boot it crashed when the
> the sdcard slot is addressed.
>
> After long search in the net i found this:
>
> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
>
> After changing the pin definitions accordingly erverything works.
> Uart_c is functioning and sdcard ist working.
>
>
> Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
> Signed-off-by: Otto Meiergf435@gmx.net

Looks like a simple fix to me, Martin could you take a look?

Yours,
Linus Walleij

Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c

[Neil Armstrong]

Hi Linus,

On 12/09/2019 11:21, Linus Walleij wrote:
> On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:
> 
>> Hi i tried to use the uart_C of the the odroid-c2.
>>
>> I enabled it in the dts file. During boot it crashed when the
>> the sdcard slot is addressed.
>>
>> After long search in the net i found this:
>>
>> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
>>
>> After changing the pin definitions accordingly erverything works.
>> Uart_c is functioning and sdcard ist working.
>>
>>
>> Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
>> Signed-off-by: Otto Meiergf435@gmx.net
> 
> Looks like a simple fix to me, Martin could you take a look?

Martin asked Otto to resend with a proper formatting, but seem he forgot to
CC linux-amlogic this time.

If the original mail is https://www.spinics.net/lists/linux-gpio/msg42278.html
It's Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

It was already reported in June 2018, but without a valid name for sign-off.

Neil

> 
> Yours,
> Linus Walleij
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 

Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c

[Martin Blumenstingl]

Hi Linus,

On Thu, Sep 12, 2019 at 11:21 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:
>
> > Hi i tried to use the uart_C of the the odroid-c2.
> >
> > I enabled it in the dts file. During boot it crashed when the
> > the sdcard slot is addressed.
> >
> > After long search in the net i found this:
> >
> > https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
> >
> > After changing the pin definitions accordingly erverything works.
> > Uart_c is functioning and sdcard ist working.
> >
> >
> > Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
> > Signed-off-by: Otto Meiergf435@gmx.net
>
> Looks like a simple fix to me, Martin could you take a look?
this looks fine to me based on the description on the Odroid forums so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Martin