From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FDFC32771 for ; Fri, 19 Aug 2022 22:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239429AbiHSWPh (ORCPT ); Fri, 19 Aug 2022 18:15:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239418AbiHSWPf (ORCPT ); Fri, 19 Aug 2022 18:15:35 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33096BD167; Fri, 19 Aug 2022 15:15:34 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id l5so4352404qtv.4; Fri, 19 Aug 2022 15:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=y3tRP3OmOA1Mjqr7eOREwc8KRFICb1q32OjHDh4TJsM=; b=jEbPEh9s+cumm1o0L0BA2XOMeUeW80GbpqgaY/cplSKb4S2rWsXib17UTbtpI89SES clIH8MPKOmVBV9g14gnrN/p/JJOqJmqBWfcllwDRc4H0HIyCD6d82g98SZpKUYro86Qs BpbR+rbl6fJa4E1IFCE8MGtu9ug++tsqPqt7qzHRQgd/CBuUSES+wSSQl2GuERMa9GtZ XGz1cdtDMYbR5K0IniawLICMdw1lsBjsRaoXOLGg03b2T3PkrQONZhLeuZhGEXCqQFtz JUG4pG9hbGeyhlwycjsgo6R2yI6UvJflAgKbVPzz9JaqYhQxbbM5Zx1kRJVEn7uTJ1zV iYIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=y3tRP3OmOA1Mjqr7eOREwc8KRFICb1q32OjHDh4TJsM=; b=2S+8JTIjwapBRu4nnd57VouFdAP7c0Rg5bO3EzawpbBdbg5XnRkEWUiROhTAKsy6DE 6Gu3v5pC+XjWrr/FyYTuGasjT6Prd7Z7uDvpN9+JcQYSg+aCQjTKKFnEY1r+b9K1Y7Y3 hfGGZyVyZjaHebLtqWJPptT/PYYVy5s6WHqaYT9FDRO30TCNtgdoa16qGQF5y5H5rP+Y BpvFuP0z1zfCVl8b17CRAprV5aRa17EUXEY/W98DAp6IoqC15aWeSb7qg1Rm/Bsjke+g lo3TQlt2B8373+VT4YF45bNE1xyprIacx4IG4KwjpRJxTLngHWPaAGWRwsDruE6WGrsn /Yhw== X-Gm-Message-State: ACgBeo03HDTtxTzq9ZvKR4dNJpBOO0oUj0wxM59bqJaGLb/P3HtauvGr +KISX0bgRBkRQwAvP3E9Kn0DyA7JBXFB7chRjlg= X-Google-Smtp-Source: AA6agR6kyM1K854TsJ/Upt+Nc9BCXWYDX0voNN2Pffr5Q1TJbgolnPk6YUuSu6jd42ppIKjW5hZQjddgMNNm0iHm/08= X-Received: by 2002:a05:622a:491:b0:344:95bf:8f05 with SMTP id p17-20020a05622a049100b0034495bf8f05mr6740137qtx.61.1660947333248; Fri, 19 Aug 2022 15:15:33 -0700 (PDT) MIME-Version: 1.0 References: <20220815091929.130547-1-brgl@bgdev.pl> In-Reply-To: <20220815091929.130547-1-brgl@bgdev.pl> From: Andy Shevchenko Date: Sat, 20 Aug 2022 01:14:57 +0300 Message-ID: Subject: Re: [PATCH] gpio: pxa: use devres for the clock struct To: Bartosz Golaszewski Cc: Robert Jarzmik , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Hulk Robot , Yuan Can Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Aug 15, 2022 at 12:26 PM Bartosz Golaszewski wrote: > > The clock is never released after probe(). Use devres to not leak > resources. ... > - clk = clk_get(&pdev->dev, NULL); > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > if (IS_ERR(clk)) { > dev_err(&pdev->dev, "Error %ld to get gpio clock\n", > PTR_ERR(clk)); > return PTR_ERR(clk); Shouldn't we fix a potential log saturation issue first (by switching to use dev_err_probe() helper)? > } -- With Best Regards, Andy Shevchenko