From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688E7C433C1 for ; Tue, 30 Mar 2021 10:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C2C661990 for ; Tue, 30 Mar 2021 10:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231537AbhC3Kyv (ORCPT ); Tue, 30 Mar 2021 06:54:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbhC3Kyf (ORCPT ); Tue, 30 Mar 2021 06:54:35 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD5EBC061574; Tue, 30 Mar 2021 03:54:35 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id h25so11461081pgm.3; Tue, 30 Mar 2021 03:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GfTXsCc8VwOCrzz5IdVCXT4sti0I4o6ulUxkv8FeK7g=; b=YJAH/noyJneTpA0X43ErEz/UFsFEgkwZ3ukM7fGy4VRntqNAUK46Ay8zaGC6HZFdFe bLJjJwhtq6sieA9mutlfAU5p8c+v2REPkBDgqjFSSnIMsw8O4jf2P2BteogNq6PDB2nK 7DWMWUCZ7pKisRqqAOgh/TsEC2S28DuvUmdShd4rFGmFMvB83NfLa7iz41JKIHEI1aGN LHky3qSLnQL2CS90SYvVtaHCEvgQZfvx9W//ENYy6aDEdYdP6Nv7jUuCd3hbm2WwrUlV JzTMUkC6SCO5CPbF9d+yYRxRbtOPTtHUedrx2YLDT1EyJDr3SCWl+CBKfrvDTztU6gxO GMcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GfTXsCc8VwOCrzz5IdVCXT4sti0I4o6ulUxkv8FeK7g=; b=CzpyyWVbQja/1Pjps6/RmR7p066nkwhWgskii4gR8x03woeRLaNpzNl3aaPUCrYj4G 9Gz+wvukI55ar/9Hw7gofZiA3LKEGsdLT214MPe1wy60Hgf/B9QHmjY5PpawgdMpIMHe +3TdX2AptJTdYhBEbCtaHvrIYKaoX+jZEK/vf/7uAY5ALakdXPthF1XKIgUDt7TB30wH kT1+7x2JhSRfpTxPgCRS7K4zzB0eldgge9Q/i5Jx2XRBJ3/KxmyC/TpdQfE77zlUKLGP bmU4DtnaBYDz9c69tbn/W8ACDQkiBGOn7nppSoli6o4jthLInKxNSYZazfqCSXMpFevs AFGg== X-Gm-Message-State: AOAM5332FOp+x0+NmN7c3EWmsMAh+Ygrc7fSBkPSieD3Ko7NHEcW6kXF gb63mv9MWt72deUd5acatCduo7Q09aKusmMKfLk= X-Google-Smtp-Source: ABdhPJyYjv0zrkk92HwCcZoSJd1Qt05pjq4R9mTJrwEJ6hv3FeLZ0+qIgtMm4U7QFaRNmO5DhyiNwMiZi7sLoxYeXGw= X-Received: by 2002:a63:c48:: with SMTP id 8mr5797418pgm.74.1617101675189; Tue, 30 Mar 2021 03:54:35 -0700 (PDT) MIME-Version: 1.0 References: <118a6160880a212d20d0251f763cad295c741b4d.1617020713.git.matti.vaittinen@fi.rohmeurope.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 30 Mar 2021 13:54:19 +0300 Message-ID: Subject: Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs To: Matti Vaittinen Cc: Lee Jones , Rob Herring , Linus Walleij , Bartosz Golaszewski , devicetree , Linux Kernel Mailing List , linux-power , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen wrote: > On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: ... > Andy, how fatal do you think these issues are? I did put these comments > on my 'things to clean-up' list. > > If you don't see them as fatal, then I rather not resend whole series > of 19 patches just for these. I am anyway going to rework the ROHM PMIC > GPIO drivers which I have authored during the next couple of months for > regmap_gpio usage. This series has most of the acks except for the > regulator part - so I was about to suggest to Lee that perhaps he could > apply other but regulator stuff to MFD so I could squeeze the recipient > list and amount of patches in series. I understand that. I'm not a maintainer, but my personal view is that it can be fixed in follow ups. The problem as usual here is that people often forget to cook / send follow up. That's why lately I'm more insisting on changes to be done as soon as possible. -- With Best Regards, Andy Shevchenko