From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v3 1/2] ACPI: Add stubs for wakeup handler functions
Date: Fri, 22 Oct 2021 15:57:24 +0300 [thread overview]
Message-ID: <CAHp75VcoKYvbMpAmyDjkBtt1bL96RwSD0DYcb96hRO6n3aXe9A@mail.gmail.com> (raw)
In-Reply-To: <20211019160401.8296-1-mario.limonciello@amd.com>
On Tue, Oct 19, 2021 at 7:05 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
Thanks! My comments below.
> commit ddfd9dcf270c ("ACPI: PM: Add acpi_[un]register_wakeup_handler()")
The commit
> added new functions for drivers to use during the s2idle wakeup path, but
> didn't add stubs for when CONFIG_ACPI wasn't set.
>
> Add those stubs in for other drivers to be able to use.
...
> +static inline int acpi_register_wakeup_handler(
> + int wake_irq, bool (*wakeup)(void *context), void *context)
A bit of a strange indentation. Can wake_irq be on the previous line?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-10-22 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 16:04 [PATCH v3 1/2] ACPI: Add stubs for wakeup handler functions Mario Limonciello
2021-10-19 16:04 ` [PATCH v3 2/2] pinctrl: amd: Fix wakeups when IRQ is shared with SCI Mario Limonciello
2021-10-22 11:09 ` Basavaraj Natikar
2021-10-22 11:17 ` [PATCH v3 1/2] ACPI: Add stubs for wakeup handler functions Basavaraj Natikar
2021-10-22 12:54 ` Rafael J. Wysocki
2021-10-22 20:32 ` Limonciello, Mario
2021-10-22 12:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcoKYvbMpAmyDjkBtt1bL96RwSD0DYcb96hRO6n3aXe9A@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).