From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Sebastian Reichel" <sre@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Phil Reid" <preid@electromag.com.au>
Subject: Re: [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17
Date: Sun, 30 Aug 2020 20:44:13 +0300 [thread overview]
Message-ID: <CAHp75Vd0Qqk3mMyA404a4MYEQbYVLmL1vwSm2UOr4Zm0gwiydQ@mail.gmail.com> (raw)
In-Reply-To: <20200828213226.1734264-1-thomas.preston@codethink.co.uk>
On Sat, Aug 29, 2020 at 12:33 AM Thomas Preston
<thomas.preston@codethink.co.uk> wrote:
>
> Hi again,
> Second round of these mcp23s03 driver fixups.
v2 makes sense to me, thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Changes since v1:
> - Split up the fixups patch.
> - I'm pretty certain the "mcp23x16" structs are typos, so I put it as
> 0001, because the second patch doesn't really make sense without it.
> - I lost the `(MCP_GPIO << 1) + 1` changes because the regmap handles
> GPIOB 0x13 with `.val_bits = 16`.
> - Dropped the interrupt-controller changes.
>
> Thanks again,
> Thomas
>
> Thomas Preston (2):
> pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser
> pinctrl: mcp23s08: Fix mcp23x17 precious range
>
> drivers/pinctrl/pinctrl-mcp23s08.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> --
> 2.26.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-30 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 21:32 [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17 Thomas Preston
2020-08-28 21:32 ` [PATCH v2 1/2] pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser Thomas Preston
2020-08-28 21:32 ` [PATCH v2 2/2] pinctrl: mcp23s08: Fix mcp23x17 precious range Thomas Preston
2020-08-30 17:43 ` Andy Shevchenko
2020-08-30 17:44 ` Andy Shevchenko [this message]
2020-09-12 9:31 ` [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd0Qqk3mMyA404a4MYEQbYVLmL1vwSm2UOr4Zm0gwiydQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jan.kundrat@cesnet.cz \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=sre@kernel.org \
--cc=thomas.preston@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).