From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Zheyu Ma <zheyuma97@gmail.com>, Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] gpio: ml-ioh: Convert to use managed functions pcim* and devm_*
Date: Fri, 20 May 2022 15:41:16 +0200 [thread overview]
Message-ID: <CAHp75Vd0jS6vv5C-NDtyLLPHHR15r2mL1=-qdPDdbTo47dxmFw@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=MfeEjJ0bGaDgkYOxYA1pi+8376zis=V1Hyvy5K3AKCAxA@mail.gmail.com>
On Fri, May 20, 2022 at 1:33 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Fri, May 20, 2022 at 4:56 AM Zheyu Ma <zheyuma97@gmail.com> wrote:
> >
> > When removing the module, we will get the following flaw:
> >
> > [ 14.204955] remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'gpio_ml_ioh'
> > [ 14.205827] WARNING: CPU: 0 PID: 305 at fs/proc/generic.c:717 remove_proc_entry+0x389/0x3f0
> > ...
> > [ 14.220613] ioh_gpio_remove+0xc5/0xe0 [gpio_ml_ioh]
> > [ 14.221075] pci_device_remove+0x92/0x240
> >
> > Fix this by using managed functions, this makes the error handling more
> > simpler.
> >
> > Fixes: e971ac9a564a ("gpio: ml-ioh: use resource management for irqs")
> Looks so much better now, gotta love devres. :)
>
> If Andy takes it through his tree:
>
> Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
>
> Otherwise let me know, I can pick it up myself too.
It's too late in the cycle, I don't believe I have time to pick this
up. Go ahead to proceed it!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-20 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 2:56 [PATCH v3] gpio: ml-ioh: Convert to use managed functions pcim* and devm_* Zheyu Ma
2022-05-20 11:33 ` Bartosz Golaszewski
2022-05-20 13:41 ` Andy Shevchenko [this message]
2022-05-20 13:48 ` Andy Shevchenko
2022-05-20 17:21 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd0jS6vv5C-NDtyLLPHHR15r2mL1=-qdPDdbTo47dxmFw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).