From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-pwm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] gpio: pca953x: Add Maxim MAX7313 PWM support
Date: Tue, 5 Nov 2019 09:06:37 +0200 [thread overview]
Message-ID: <CAHp75VdULzZ6NXP7fp=6KQFAHOSvoJ-_WTqfcmhQJbrLUw3M4Q@mail.gmail.com> (raw)
In-Reply-To: <20191104203346.epdbzflnynh2gf3z@pengutronix.de>
On Mon, Nov 4, 2019 at 10:33 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Mon, Nov 04, 2019 at 04:32:23PM +0100, Bartosz Golaszewski wrote:
> > pon., 4 lis 2019 o 16:11 Miquel Raynal <miquel.raynal@bootlin.com> napisał(a):
> > > Andy Shevchenko <andy.shevchenko@gmail.com> wrote on Tue, 15 Oct 2019
> > > 17:55:33 +0300:
> > >
> > > > Or other way around. PWM registers GPIO (which actually I prefer since
> > > > we have PCA9685 case where PWM provides GPIO functionality, though via
> > > > different means)
> While it's not nice to have a driver that provides two different devices
> (here: gpio controller and pwm controller) similar things are not
> unseen. And for example the splitting of watchdog
> (drivers/watchdog/stmp3xxx_rtc_wdt.c) and rtc
> (drivers/rtc/rtc-stmp3xxx.c) of the device in the mx28 is more trouble
> than worth.
>
> So I'd vote for putting it in a single file that lives where the
> bigger/more complex part fits to. So assuming that's the GPIO part (as
> the driver supports several variants and not all of them have a PWM
> function if I'm not mistaken) having it in drivers/gpio is fine for me.
For me it sounds more likely that PWM is a *pin function* of a pin
controller and actually this GPIO driver should be a pin controller
with corresponding function(s).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-05 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 12:48 [PATCH] gpio: pca953x: Add Maxim MAX7313 PWM support Miquel Raynal
2019-10-14 13:10 ` Thierry Reding
2019-10-14 15:53 ` kbuild test robot
2019-10-14 17:59 ` Andy Shevchenko
2019-10-15 14:30 ` Miquel Raynal
2019-10-15 14:55 ` Andy Shevchenko
2019-11-04 15:11 ` Miquel Raynal
2019-11-04 15:32 ` Bartosz Golaszewski
2019-11-04 20:33 ` Uwe Kleine-König
2019-11-05 7:06 ` Andy Shevchenko [this message]
2019-11-05 9:01 ` Miquel Raynal
2019-11-05 9:08 ` Andy Shevchenko
2019-11-05 14:44 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdULzZ6NXP7fp=6KQFAHOSvoJ-_WTqfcmhQJbrLUw3M4Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).