From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Peng Fan <peng.fan@nxp.com>, Ran Rozenstein <ranro@nvidia.com>,
gal@nvidia.com, Leon Romanovsky <leonro@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH gpio] gpio: vf610: fix compilation error
Date: Tue, 5 Jul 2022 12:31:17 +0200 [thread overview]
Message-ID: <CAHp75Vdkfz9JSnEjaUAxMfVSQGP+eb04U1Nw3G7_8mRMN9SLWQ@mail.gmail.com> (raw)
In-Reply-To: <20220705102114.2067-1-tariqt@nvidia.com>
On Tue, Jul 5, 2022 at 12:21 PM Tariq Toukan <tariqt@nvidia.com> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fix compilation error by explicitly adding the missing include.
>
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
> 120 | return pinctrl_gpio_direction_input(chip->base + gpio);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | vf610_gpio_direction_input
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> drivers/gpio/gpio-vf610.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
>
> #define VF610_GPIO_PER_PORT 32
>
> --
> 2.21.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-05 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 10:21 [PATCH gpio] gpio: vf610: fix compilation error Tariq Toukan
2022-07-05 10:31 ` Andy Shevchenko [this message]
2022-07-05 12:52 ` Peng Fan
2022-07-05 13:59 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vdkfz9JSnEjaUAxMfVSQGP+eb04U1Nw3G7_8mRMN9SLWQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ranro@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).