From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexander Dahl <ada@thorsis.com>
Cc: Linux Documentation List <linux-doc@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 1/3] docs: gpio: mockup: Fix parameter name
Date: Wed, 31 Mar 2021 15:27:05 +0300 [thread overview]
Message-ID: <CAHp75VdqtWS15YPvaPvy4yj5TdW7DDgFB+_bbavFqPBp1zm6eg@mail.gmail.com> (raw)
In-Reply-To: <20210329111648.7969-2-ada@thorsis.com>
On Mon, Mar 29, 2021 at 2:18 PM Alexander Dahl <ada@thorsis.com> wrote:
>
> Module probing with the parameter documented yielded this in kernel log:
>
> gpio_mockup: unknown parameter 'gpio_named_lines' ignored
>
> The parameter documented did not match the parameter actually
> implemented with commit 8a68ea00a62e ("gpio: mockup: implement naming
> the lines") long before introducing the documentation.
>
> Fixes: commit 2fd1abe99e5f ("Documentation: gpio: add documentation for gpio-mockup")
Alexander, in the entire series you are using the wrong format for the
Fixes tag.
I highly recommend to add in your .gitconfig file an alias:
one = show -s --pretty='format:%h (\"%s\")'
`git one <commit ID>` will give you proper value to refer to the
commit in question.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-31 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 11:16 [PATCH 0/3] docs: gpio: mockup: Fix parameter name and missing entry Alexander Dahl
2021-03-29 11:16 ` [PATCH 1/3] docs: gpio: mockup: Fix parameter name Alexander Dahl
2021-03-31 7:44 ` Bartosz Golaszewski
2021-03-31 12:27 ` Andy Shevchenko [this message]
2021-03-31 12:53 ` Alexander Dahl
2021-03-31 18:31 ` Bartosz Golaszewski
2021-03-29 11:16 ` [PATCH 2/3] docs: kernel-parameters: Move gpio-mockup for alphabetic order Alexander Dahl
2021-03-31 7:46 ` Bartosz Golaszewski
2021-03-29 11:16 ` [PATCH 3/3] docs: kernel-parameters: Add gpio_mockup_named_lines Alexander Dahl
2021-03-31 7:46 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdqtWS15YPvaPvy4yj5TdW7DDgFB+_bbavFqPBp1zm6eg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=ada@thorsis.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).