From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linus.walleij@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
richardcochran@gmail.com, manivannan.sadhasivam@linaro.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 3/3] pinctrl: qcom: Add SDX75 pincontrol driver
Date: Wed, 3 May 2023 12:47:37 +0300 [thread overview]
Message-ID: <CAHp75Ve0FqX7=x3B5eaCfj0AE5m1qMXGrYzLoHzqbLY7gdOSOg@mail.gmail.com> (raw)
In-Reply-To: <1683092380-29551-4-git-send-email-quic_rohiagar@quicinc.com>
On Wed, May 3, 2023 at 8:39 AM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
>
> Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
> with pinctrl framework for SDX75 SoC.
> While at it, reordering the SDX65 entry.
...
> +#define FUNCTION(n) \
> + [msm_mux_##n] = { \
> + .func = PINCTRL_PINFUNCTION(#n, \
> + n##_groups, \
> + ARRAY_SIZE(n##_groups)) \
> + }
Or even define
#define MSM_PIN_FUNCTION(fname) \
[msm_mux_##fname] = PINCTRL_PINFUNCTION(...)
in the header for all MSM related controllers.
All the same for the rest groups (if any), otherwise use redefinition
of FUNCTION inside each file.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-05-03 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 5:39 [PATCH v5 0/3] Add pinctrl support for SDX75 Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 1/3] dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver Rohit Agarwal
2023-05-03 9:41 ` Andy Shevchenko
2023-05-03 11:14 ` Rohit Agarwal
2023-05-03 13:53 ` Andy Shevchenko
2023-05-05 6:56 ` Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 3/3] pinctrl: qcom: Add SDX75 pincontrol driver Rohit Agarwal
2023-05-03 9:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve0FqX7=x3B5eaCfj0AE5m1qMXGrYzLoHzqbLY7gdOSOg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).