From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Stephen Boyd <swboyd@chromium.org>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hulk Robot <hulkci@huawei.com>,
"Signed-off-by : Yuan Can" <yuancan@huawei.com>
Subject: Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct
Date: Wed, 6 Jul 2022 13:48:26 +0200 [thread overview]
Message-ID: <CAHp75Ve3sPhFOZhL=_2p+1avuo96CP995KD+bi+Pn3gyj1F9TA@mail.gmail.com> (raw)
In-Reply-To: <20220705171835.4923-1-brgl@bgdev.pl>
On Tue, Jul 5, 2022 at 7:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> The clock is never released after probe(). Schedule devm actions for
> putting and disabling the clock.
...
> Reported-by: Signed-off-by: Yuan Can <yuancan@huawei.com>
Me puzzled.
...
> + ret = devm_add_action_or_reset(&pdev->dev, pxa_gpio_clk_put, clk);
> + if (ret)
> + return ret;
> +
> ret = clk_prepare_enable(clk);
> + if (ret)
> + return ret;
> +
> + ret = devm_add_action_or_reset(&pdev->dev,
> + pxa_gpio_clk_disable_unprepare, clk);
> + if (ret)
> return ret;
Can we use recently introduced clk APIs for that? Maybe Stephen has an
immutable branch you may reuse?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-06 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 17:18 [PATCH] gpio: pxa: schedule a devm action for the clock struct Bartosz Golaszewski
2022-07-06 11:48 ` Andy Shevchenko [this message]
2022-07-06 12:11 ` Bartosz Golaszewski
2022-07-06 12:31 ` Andy Shevchenko
2022-07-06 15:07 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve3sPhFOZhL=_2p+1avuo96CP995KD+bi+Pn3gyj1F9TA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hulkci@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=swboyd@chromium.org \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).