From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Srinivas Neeli <srinivas.neeli@xilinx.com>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
neelisrinivas18@gmail.com,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
srinivas.neeli@amd.com, Srinivas Goud <sgoud@xilinx.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
git <git@xilinx.com>
Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow
Date: Mon, 25 Jul 2022 22:29:34 +0200 [thread overview]
Message-ID: <CAHp75VeB0Tago2foASYcGn_YUoh_HigDDag_X5WMTibRXxi72Q@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdWS9DKd=xs8Kitoo9GZCsiNf7gt5HjfZn-9zNXBdvMEg@mail.gmail.com>
On Mon, Jul 25, 2022 at 10:21 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> > > <srinivas.neeli@xilinx.com> wrote:
...
> Reading again... You mean that
>
> unsigned long x = y << 32;
>
> wouldn't work?
Yeah, I even checked this in asm, and indeed it doesn't work. Don't
know what was that about me...
Thanks for the fix,
Reviewed-by: Andy Shevchenko <andy.shevchenlko@gmail.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-07-25 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 7:39 [PATCH] gpio: gpio-xilinx: Fix integer overflow Srinivas Neeli
2022-07-22 7:17 ` Bartosz Golaszewski
2022-07-25 20:04 ` Andy Shevchenko
2022-07-25 20:21 ` Andy Shevchenko
2022-07-25 20:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeB0Tago2foASYcGn_YUoh_HigDDag_X5WMTibRXxi72Q@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=git@xilinx.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=neelisrinivas18@gmail.com \
--cc=sgoud@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=srinivas.neeli@amd.com \
--cc=srinivas.neeli@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).