From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61981C433EF for ; Mon, 25 Jul 2022 20:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236668AbiGYUaS (ORCPT ); Mon, 25 Jul 2022 16:30:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237089AbiGYUaQ (ORCPT ); Mon, 25 Jul 2022 16:30:16 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57EEC26F8; Mon, 25 Jul 2022 13:30:12 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id m8so15419849edd.9; Mon, 25 Jul 2022 13:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OGiLPxDzhs5DzTm0Q7KOkKqc68yALSJCaG0MVt2d3Bo=; b=qSnjCxXcMIEKC2hKuEYGjtRVQxfLdLQZPWamsT/EKIOGAuWBwJmmvkzPzDx+BU+qJ8 WQSQc+Qwwn8Ew7odBh8x1SZ6L6fLruTRZ8GJY0PyE5bQSURCk4ljqPT7GFTrPysBTb+C X9IGKgV0ClJ6a9zyHHEAWDREJlMNkp0p8BAzvbeRyX7hlvw1hWlYrD8wnNWQugb9V8kQ /vKkzaGj4wWA/e0Eygq/PDuJqFpVERl5fTa+2vn8K0/qWu1vR6iBgS6syJp0Fe+U8+hS p3M1E4tedPzj54EsAisKtedD2BWi3nVKFIBDHNfM3KhsHR2bPq1nOH/F/5UcgYV1Bqv7 0PSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OGiLPxDzhs5DzTm0Q7KOkKqc68yALSJCaG0MVt2d3Bo=; b=EbzduVrYFqH3Mw47XiXViJrwoQOxf+zXEut1WrvPVQ8qwKktZUw20PzxEoPCxBzKFR nXcmB6szEXY2TVnuaMxbUWTYC1pNuFLzGDeFKgDR0odLelET0edXnBArxFvKuyrGrfAS LBlLX+qpxoels0CTKkxXNs4j+yEOgq22TJZVy9BWjPP2r2YnwV53JCS/lcVXjHaTnSeE KB9udFoaNKQ+FpWEPtJIGZGgkIxfDBvTEpeu/I8JPkd6n4Ci0OP0fQDNiMF4RLZXlArL BJtzxaGdjYC6ra/Q/Kg54MMAxFQ3FDIEWGWwLmJUORqhFf5pBHkhYqqjjfCfsaN+GzmZ 0mRw== X-Gm-Message-State: AJIora9J2pucLIfFFMtHyk2HumXKqoKWEMHao11iJgk8E7TtDLWShG1a 7JQwizTeep/ZOs6ZI3Fa9sOoP1KeVh6BLYLuEhY= X-Google-Smtp-Source: AGRyM1v203+pQvF3wPtPOxUgVQcpVbocuHjseuhqyPUxKlDe7PG86NUrZhAJfIf+dRNmgYJI4ZCLWZOheS6nDxI5U3s= X-Received: by 2002:a05:6402:d53:b0:43b:a0cf:d970 with SMTP id ec19-20020a0564020d5300b0043ba0cfd970mr14632305edb.277.1658781010950; Mon, 25 Jul 2022 13:30:10 -0700 (PDT) MIME-Version: 1.0 References: <20220721073909.23318-1-srinivas.neeli@xilinx.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 25 Jul 2022 22:29:34 +0200 Message-ID: Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow To: Bartosz Golaszewski Cc: Srinivas Neeli , Linus Walleij , Michal Simek , neelisrinivas18@gmail.com, Shubhrajyoti Datta , srinivas.neeli@amd.com, Srinivas Goud , "open list:GPIO SUBSYSTEM" , Linux ARM , Linux Kernel Mailing List , git Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jul 25, 2022 at 10:21 PM Andy Shevchenko wrote: > On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko > wrote: > > On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski wrote: > > > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli > > > wrote: ... > Reading again... You mean that > > unsigned long x = y << 32; > > wouldn't work? Yeah, I even checked this in asm, and indeed it doesn't work. Don't know what was that about me... Thanks for the fix, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko