From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linus.walleij@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
richardcochran@gmail.com, manivannan.sadhasivam@linaro.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver
Date: Wed, 3 May 2023 16:53:50 +0300 [thread overview]
Message-ID: <CAHp75VekkTVzVCJs10GEi=1Andb2rWTwK8RELw6SqMzKYCPq2w@mail.gmail.com> (raw)
In-Reply-To: <20a45e1e-6e62-9940-33d8-af7bad02b68d@quicinc.com>
On Wed, May 3, 2023 at 2:14 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
> On 5/3/2023 3:11 PM, Andy Shevchenko wrote:
> > On Wed, May 3, 2023 at 8:39 AM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
...
> >> /**
> >> * struct msm_function - a pinmux function
> >> - * @name: Name of the pinmux function.
> >> - * @groups: List of pingroups for this function.
> >> - * @ngroups: Number of entries in @groups.
> >> + * @func: Generic data of the pin function (name and groups of pins)
> >> */
> >> struct msm_function {
> >> - const char *name;
> >> - const char * const *groups;
> >> - unsigned ngroups;
> >> + struct pinfunction func;
> >> };
> > But why? Just kill the entire structure.
> Got it. Can we have a typedef for pinfunction to msm_function in the msm
> header file?
But why? You can replace the type everywhere it needs to be replaced.
I can't expect many lines to change.
Also consider splitting struct pingroup change out of this. We will
focus only on the struct pinfunction change and less code to review.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-03 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 5:39 [PATCH v5 0/3] Add pinctrl support for SDX75 Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 1/3] dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver Rohit Agarwal
2023-05-03 9:41 ` Andy Shevchenko
2023-05-03 11:14 ` Rohit Agarwal
2023-05-03 13:53 ` Andy Shevchenko [this message]
2023-05-05 6:56 ` Rohit Agarwal
2023-05-03 5:39 ` [PATCH v5 3/3] pinctrl: qcom: Add SDX75 pincontrol driver Rohit Agarwal
2023-05-03 9:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VekkTVzVCJs10GEi=1Andb2rWTwK8RELw6SqMzKYCPq2w@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).