From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges()
Date: Tue, 18 Nov 2025 14:04:43 +0200 [thread overview]
Message-ID: <CAHp75VeuX1BWnx5wH=c9WwuiC10H3SOEPJetYhQ59mJhgBGGqA@mail.gmail.com> (raw)
In-Reply-To: <20251118114730.GG2912318@black.igk.intel.com>
On Tue, Nov 18, 2025 at 1:47 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Nov 17, 2025 at 08:57:00AM +0100, Andy Shevchenko wrote:
> > Export intel_gpio_add_pin_ranges() for reuse in other drivers.
...
> > -static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
>
> As this is now exported, can you add kernel-doc too?
OK.
...
> > +int intel_gpio_add_pin_ranges(struct gpio_chip *gc);
>
> Can you move this down a bit, above intel_get_groups_count()?
Sure.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-18 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 7:56 [PATCH v1 0/3] pinctrl: intel: Export intel_gpio_add_pin_ranges() and use it Andy Shevchenko
2025-11-17 7:56 ` [PATCH v1 1/3] pinctrl: intel: Refactor intel_gpio_add_pin_ranges() to make it shorter Andy Shevchenko
2025-11-17 11:27 ` Mika Westerberg
2025-11-17 16:06 ` Andy Shevchenko
2025-11-18 5:27 ` Mika Westerberg
2025-11-18 10:02 ` Andy Shevchenko
2025-11-17 7:57 ` [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges() Andy Shevchenko
2025-11-18 11:47 ` Mika Westerberg
2025-11-18 12:04 ` Andy Shevchenko [this message]
2025-11-17 7:57 ` [PATCH v1 3/3] pinctrl: cherryview: Convert to use intel_gpio_add_pin_ranges() Andy Shevchenko
2025-11-18 11:47 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeuX1BWnx5wH=c9WwuiC10H3SOEPJetYhQ59mJhgBGGqA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).