From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69CDA32860C for ; Wed, 19 Nov 2025 07:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763539012; cv=none; b=qLU9SF2IJEEhXJOwvuVFGUEi/yIRZW5JXaFTJvkl0gYoP4JrPaL6Yhp6CZJfQ46hvBLVx/lKwjS+g9IE1j3o8DegAk/JJfpemSD6rebxIFUygWkYmCUWGmxu3dumHqb2xgS5OwXhdm9cVvSSDb2uRlWj34mIKqGe4OtiN6ojdk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763539012; c=relaxed/simple; bh=Wl+eqGRqfTTSr73sNBFdhSQqOrm3v/7atKhJ2Ue8nRQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uaERkWZYutHGOzo6eRMCgiOq/aflm6QyKCFdkyv6qdnA0Cs1b4gJUuqYGapfEbx9rlPeNiaDnRI7PLXb371aIRsqi0wPp9dGRK7oQXtbRCJ9Dw6UmlUFB0CEUt0TPvkRVRZea5+odtIQU6T4ZL2U/aYzFF/dCm+6aHVdJgLP768= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cFIoUq8j; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cFIoUq8j" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b7277324054so891949166b.0 for ; Tue, 18 Nov 2025 23:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763539009; x=1764143809; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XT2jT53GtflpgtsSSARNMehrU8xMcefHmEbO5weE+H8=; b=cFIoUq8jBGkxS6Nm+iIernUD4Jw4H3KjuHGzf7JgJYADTcSEUddK5r8tz2oghhqxj9 f78zclONnAb4rs26C7XQNzOq0THYLV0VXnxjkrweuzaYT1a67OlGV4l9IwFV9BpngTZI wWfzxYVVrDaB3re+hLDkZZYYA6lPKW2QCQhOYbj+3g5WjZcAKbrt/OY2CqZKfyDrHVK2 tuaMTaYUbSCnmPQXQgIyPb7gcQ6YuXbauyAYEv68T7wLo9iC2776c5z/fUGM1VURALi7 eLQM29keCVUmwccS9s/ZDUIQUScq74Z+/6uHsknzRYxfzQ7Y6PzGG1V7EbRbCIEWpZ6E fUaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763539009; x=1764143809; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XT2jT53GtflpgtsSSARNMehrU8xMcefHmEbO5weE+H8=; b=toi6ALjoxsYUzZ2Rz6H5YoXXeIpooejry26X4HdayVoGkafmhDoSdsSbggOHv8ro50 kJOQm/wmmgBabp6EMjhDDnhxBwnnvxz6GbpYsunHfxzYzi0A7rCYiYW1ycqIEsCo7mHo UNmG3Zo8+CI0YX43g/E51QkTN9K9F9JSif897d3GCzTA8rnyYIKQwazs/5XZujmtJjG+ HRGzyi+Cs3UwB5SAUruA5bkpTlDoe56QlrASY0ZbzNzRQ7qvefAv5EQQuqZcZHP9Um91 oyzv+8VkM34o/dMpF6Ic3hqc0zftuj4/7jlHZh40Z5hYfDpmJ/YM4Eh2nMFhIPI3z3Ol W5Gw== X-Forwarded-Encrypted: i=1; AJvYcCXLaaWz0xRx3U40JAb+lKmm/I5sZGp+2rcQNElll61y/Wk6fth72gxRwGzSm/CqC1y7P/07sqXuy5jI@vger.kernel.org X-Gm-Message-State: AOJu0YzwW73cVPLczodHfsPLBvewtxpVr2Nb7t3q81eOj/cd0KHIkEzP 3fJIN91thH3Tbvs+3cOMazYqnxAmnZvQjoTY3Jf/0o9pOHv1SQMS8IusM0mUYQwSUVA+8/J6rf4 YW4csBrINmwIM1h5oQeIrH+KqbtD7ri4= X-Gm-Gg: ASbGncsIhAOgQmW1U8clRpkYLuTyGg/5IntXfJCHqWo+wqaXu0NSfwKvDccwbOpHzx4 lYjhmrUCPM/8d8j8LuNPhdUZkf0VAuZh/G8ABHEVL4PdeQKfMln5RS9fq2/KlcvV6aRKiBG43zT Tx4xp9jMevv0vgTMq2mHM1VmSnaCDbOKPuE1km0TzEfZHrEh1pWqg9fkMvUWIPHe2axGcg5Tm6E q9um+9mClUo45jwilkppgPzXW93J6fpoVvz8tez6SnqWGUUMZx5Ggkx9AOgdW4kVITxImPUuo8L G2YR7QQC1k5f6BFD/qK8Cw7ASoWu/0SB88Ny5cExgaqIJEBPqgLZLZ15YliiryY8HU3Tr1KU+7Z Xi//PU64= X-Google-Smtp-Source: AGHT+IHkr98iv8RkJCJVqsJKrbJ1+s/zkdGOwfF/rH8mGb3+ej0aXWY1sLaOq7gDCGS9Bl34YEhC4czuLVOsZWaGVgA= X-Received: by 2002:a17:906:7304:b0:b72:a899:168d with SMTP id a640c23a62f3a-b73677edba0mr1946935566b.13.1763539008473; Tue, 18 Nov 2025 23:56:48 -0800 (PST) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251118003229.26636-1-jszhang@kernel.org> <20251118003229.26636-6-jszhang@kernel.org> In-Reply-To: From: Andy Shevchenko Date: Wed, 19 Nov 2025 09:56:12 +0200 X-Gm-Features: AWmQ_bmed1VXCExSbCiDJjR0DcoAiO6hz3YdSi7TR0YlyvVDegjc7dB_x9IoTzM Message-ID: Subject: Re: [PATCH v2 05/15] gpio: pxa: Use modern PM macros To: Robert Jarzmik Cc: Jisheng Zhang , Doug Berger , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Linus Walleij , Bartosz Golaszewski , Hoan Tran , Andy Shevchenko , Daniel Palmer , Romain Perier , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Kunihiko Hayashi , Masami Hiramatsu , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2025 at 12:04=E2=80=AFAM Robert Jarzmik wrote: > Andy Shevchenko writes: > > On Tue, Nov 18, 2025 at 2:50=E2=80=AFAM Jisheng Zhang > > wrote: ... > >> -#ifdef CONFIG_PM > >> unsigned long saved_gplr; > >> unsigned long saved_gpdr; > >> unsigned long saved_grer; > >> unsigned long saved_gfer; > >> -#endif > > Actually this is not equivalent to what was there before. > > With Jisheng's patch, with CONFIG_PM disabled, he adds 16 bytes to > the > structure. You might thing today, 16 bytes is nothing. True, but > on a > 64MB RAM devices, it's something. > > That might not be a reason to reject the patch, but it's not only > a > "modernisation patch". Actually a good point! On the same grounds I semi-nacked the gpio-dwapb cha= nge. --=20 With Best Regards, Andy Shevchenko