From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
linux-gpio@vger.kernel.org, imx@lists.linux.dev,
linux-imx@nxp.com
Subject: Re: [PATCH v2] gpio: mxc: release the parent IRQ in runtime suspend
Date: Thu, 10 Aug 2023 12:59:18 +0300 [thread overview]
Message-ID: <CAHp75VfB_fHD-h3Tdu=oB90Y7UC1RG2U3ECX4pymMCRFTux0Mg@mail.gmail.com> (raw)
In-Reply-To: <20230809141324.400448-1-shenwei.wang@nxp.com>
On Wed, Aug 9, 2023 at 5:13 PM Shenwei Wang <shenwei.wang@nxp.com> wrote:
>
> Release the parent interrupt request during runtime suspend, allowing
> the parent interrupt controller to enter runtime suspend if there are
> no active users.
>
> This change may not have a visible impact if the parent controller is
> the GIC, but it can enable significant power savings for parent IRQ
> controllers like IRQSteer inside a subsystem on i.MX8 SoCs. Releasing
> the parent IRQ provides an opportunity for the subsystem to enter suspend
> states if there are no active users.
Assumed that this change has been tested (esp. when an IRQ is wakeup
source), I'm fine with it,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-10 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 14:13 [PATCH v2] gpio: mxc: release the parent IRQ in runtime suspend Shenwei Wang
2023-08-10 9:59 ` Andy Shevchenko [this message]
2023-08-11 14:23 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfB_fHD-h3Tdu=oB90Y7UC1RG2U3ECX4pymMCRFTux0Mg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=imx@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).