From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v7 07/18] gpiolib: Introduce gpio_set_debounce_timeout() for internal use
Date: Thu, 12 Nov 2020 14:08:31 +0200 [thread overview]
Message-ID: <CAHp75VfEXW030w3Tnmig+8+wLFb=XUSvE9hjnZ8RPdJQxDRFZQ@mail.gmail.com> (raw)
In-Reply-To: <e176656b-81e1-d9f8-a108-ac8376f6c136@redhat.com>
On Thu, Nov 12, 2020 at 1:12 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 11/12/20 12:06 PM, Mika Westerberg wrote:
> > On Thu, Nov 12, 2020 at 12:19:37PM +0200, Andy Shevchenko wrote:
> >> On Thu, Nov 12, 2020 at 10:17 AM Mika Westerberg
> >> <mika.westerberg@linux.intel.com> wrote:
> >>> On Thu, Nov 12, 2020 at 12:19:57AM +0200, Andy Shevchenko wrote:
> >>
> >> ...
> >>
> >>>> +int gpio_set_debounce_timeout(struct gpio_desc *desc, unsigned int debounce)
> >>
> >>> Sorry for commenting this late but I realized we have
> >>> gpiod_set_debounce() already. At least this new function should follow
> >>> the naming (gpiod as it takes descriptior):
> >>>
> >>> int gpiod_set_debounce_optional(struct gpio_desc *desc, unsigned int debounce);
> >>
> >> Unfortunately it will be inconsistent with the naming schema. I
> >> explained the choice of name in the cover letter. I will elaborate a
> >> bit there.
> >
> > OK, It seems that I was not CC'd cover letter of the last two versions,
> > or it got dropped somewhere.
>
> Yes I did not get the cover-letter either, I was actually wondering if there
> was one...
Oops, I dropped --cc because of your Rb tags (and I have added Cc when
there is no tag), but I forgot to add Cc to the cover letter.
Here we are [1].
[1]: https://lore.kernel.org/linux-gpio/20201111222008.39993-1-andriy.shevchenko@linux.intel.com/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-12 12:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 22:19 [PATCH v7 00/18] gpiolib: acpi: pin configuration fixes Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 01/18] gpiolib: Replace unsigned by unsigned int Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 02/18] gpiolib: add missed break statement Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 03/18] gpiolib: use proper API to pack pin configuration parameters Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 04/18] gpiolib: Extract gpio_set_config_with_argument() for future use Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 05/18] gpiolib: move bias related code from gpio_set_config() to gpio_set_bias() Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 06/18] gpiolib: Extract gpio_set_config_with_argument_optional() helper Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 07/18] gpiolib: Introduce gpio_set_debounce_timeout() for internal use Andy Shevchenko
2020-11-12 8:16 ` Mika Westerberg
2020-11-12 10:19 ` Andy Shevchenko
2020-11-12 11:06 ` Mika Westerberg
2020-11-12 11:12 ` Hans de Goede
2020-11-12 12:08 ` Andy Shevchenko [this message]
2020-11-11 22:19 ` [PATCH v7 08/18] gpiolib: acpi: Respect bias settings for GpioInt() resource Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 09/18] gpiolib: acpi: Use named item for enum gpiod_flags variable Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 10/18] gpiolib: acpi: Take into account debounce settings Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 11/18] gpiolib: acpi: Move non-critical code outside of critical section Andy Shevchenko
2020-11-12 8:17 ` Mika Westerberg
2020-11-11 22:20 ` [PATCH v7 12/18] gpiolib: acpi: Move acpi_gpio_to_gpiod_flags() upper in the code Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 13/18] gpiolib: acpi: Set initial value for output pin based on bias and polarity Andy Shevchenko
2020-11-12 9:10 ` Mika Westerberg
2020-11-11 22:20 ` [PATCH v7 14/18] gpiolib: acpi: Make acpi_gpio_to_gpiod_flags() usable for GpioInt() Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 15/18] gpiolib: acpi: Extract acpi_request_own_gpiod() helper Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 16/18] gpiolib: acpi: Convert pin_index to be u16 Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 17/18] gpiolib: acpi: Use BIT() macro to increase readability Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 18/18] gpiolib: acpi: Make Intel GPIO tree official for GPIO ACPI work Andy Shevchenko
2020-11-12 10:24 ` [PATCH v7 00/18] gpiolib: acpi: pin configuration fixes Andy Shevchenko
2020-11-12 14:16 ` Andy Shevchenko
2020-11-15 16:04 ` Linus Walleij
2020-11-16 9:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfEXW030w3Tnmig+8+wLFb=XUSvE9hjnZ8RPdJQxDRFZQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).