help with GPIOSET_INTERACTIVE

help with GPIOSET_INTERACTIVE

[Seamus de Mora]

I'm trying to add the 'GPIOSET_INTERACTIVE' definition to 'gpioset.c':
I've installed 'libeditline-dev' and 'libedit-dev' via apt; each
separately, and then both

With 'libeditline-dev' alone I am getting the compile error:
gpioset.c:16:10: fatal error: editline/readline.h: No such file or directory
   16 | #include <editline/readline.h>
      |          ^~~~~~~~~~~~~~~~~~~~~

With 'libedit-dev' alone (or both), I get these errors:
/usr/bin/ld: gpioset.o: in function `tab_completion':
/home/pi/libgpiod-2.1/tools/gpioset.c:732: undefined reference to
`rl_completion_matches'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:713: undefined
reference to `rl_completion_matches'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
reference to `rl_completion_matches'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
reference to `rl_attempted_completion_over'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
reference to `rl_completion_type'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
reference to `rl_completion_append_character'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
reference to `rl_line_buffer'
/usr/bin/ld: gpioset.o: in function `complete_line_id':
/home/pi/libgpiod-2.1/tools/gpioset.c:642: undefined reference to
`rl_line_buffer'
/usr/bin/ld: gpioset.o: in function `interact':
/home/pi/libgpiod-2.1/tools/gpioset.c:748: undefined reference to
`stifle_history'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:769: undefined
reference to `readline'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:853: undefined
reference to `history_list'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:855: undefined
reference to `add_history'
/usr/bin/ld: gpioset.o: in function `print_line_values':
/home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined reference to
`rl_attempted_completion_function'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined
reference to `rl_basic_word_break_characters'
/usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined
reference to `history_length'
collect2: error: ld returned 1 exit status
make: *** [Makefile:513: gpioset] Error 1

Can someone explain how to add GPIOSET_INTERACTIVE & compile successfully?

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Fri, Dec 29, 2023 at 03:14:04AM -0600, Seamus de Mora wrote:
> I'm trying to add the 'GPIOSET_INTERACTIVE' definition to 'gpioset.c':
> I've installed 'libeditline-dev' and 'libedit-dev' via apt; each
> separately, and then both
>

Please prefix emails related to libgpiod with [libgpiod], as noted in
the CONTRIBUTING section of the README, so your mail is more likely to
be recognized by the appropriate people.

You don't specify your platform and what you've done to get this far -
you provide the output you are seeing but not the inputs.
It is apparently a Pi, but the distro and version would be helpful,
as well as the build commands themselves.

Have you read the BUILDING section of the README?
How are you performing the build? I would expect autoconf to choke
if it can't find the required headers before it even gets to the actual
compile step.

This works for me on a Pi, both bullseye and bookworm:

$ ./autogen.sh --enable-tools --enable-gpioset-interactive
$ make

That results in tools being built in the tools directory, and the
built gpioset supports the -i option.

That is with the following packages installed:
 autoconf
 autoconf-archive
 libtool
 m4
 libedit-dev

Cheers,
Kent.

> With 'libeditline-dev' alone I am getting the compile error:
> gpioset.c:16:10: fatal error: editline/readline.h: No such file or directory
>    16 | #include <editline/readline.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~
>
> With 'libedit-dev' alone (or both), I get these errors:
> /usr/bin/ld: gpioset.o: in function `tab_completion':
> /home/pi/libgpiod-2.1/tools/gpioset.c:732: undefined reference to
> `rl_completion_matches'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:713: undefined
> reference to `rl_completion_matches'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
> reference to `rl_completion_matches'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
> reference to `rl_attempted_completion_over'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
> reference to `rl_completion_type'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
> reference to `rl_completion_append_character'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:725: undefined
> reference to `rl_line_buffer'
> /usr/bin/ld: gpioset.o: in function `complete_line_id':
> /home/pi/libgpiod-2.1/tools/gpioset.c:642: undefined reference to
> `rl_line_buffer'
> /usr/bin/ld: gpioset.o: in function `interact':
> /home/pi/libgpiod-2.1/tools/gpioset.c:748: undefined reference to
> `stifle_history'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:769: undefined
> reference to `readline'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:853: undefined
> reference to `history_list'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:855: undefined
> reference to `add_history'
> /usr/bin/ld: gpioset.o: in function `print_line_values':
> /home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined reference to
> `rl_attempted_completion_function'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined
> reference to `rl_basic_word_break_characters'
> /usr/bin/ld: /home/pi/libgpiod-2.1/tools/gpioset.c:484: undefined
> reference to `history_length'
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:513: gpioset] Error 1
>
> Can someone explain how to add GPIOSET_INTERACTIVE & compile successfully?

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Fri, Dec 29, 2023 at 9:58 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Fri, Dec 29, 2023 at 03:14:04AM -0600, Seamus de Mora wrote:
> > I'm trying to add the 'GPIOSET_INTERACTIVE' definition to 'gpioset.c':
> > I've installed 'libeditline-dev' and 'libedit-dev' via apt; each
> > separately, and then both
> >
> > Can someone explain how to add GPIOSET_INTERACTIVE & compile successfully?

> You don't specify your platform and what you've done to get this far -
> you provide the output you are seeing but not the inputs.
> It is apparently a Pi, but the distro and version would be helpful,
> as well as the build commands themselves.
>
> Have you read the BUILDING section of the README?
> How are you performing the build? I would expect autoconf to choke
> if it can't find the required headers before it even gets to the actual
> compile step.

Yes - I read the BUILDING section of the README. When I initially
installed this, I was trying to follow "the RPi way" of doing things,
and I used these commands:

$ ./autogen.sh --enable-tools=yes --prefix=/usr/lib/arm-linux-gnueabihf
$ make
$ sudo make install

This was done on an RPi 3A+, running "raspbian/RPi OS", release
"bullseye", kernel ver "6.1.21-v7+"
Why '/usr/lib/arm-linux-gnueabihf'?
    Because that's where the older ver 1.6.X version of 'libgpiod' &
the "tools" were installed.
Of course that had no effect on my issue, but just so you know.

Also: I was trying to re-compile 'gpioset' from the
'~/libgpiod-2.1/tools' folder, using 'make' - as explained below.

> This works for me on a Pi, both bullseye and bookworm:
>
> $ ./autogen.sh --enable-tools --enable-gpioset-interactive
> $ make

That option ('--enable-gpioset-interactive') seems to have gotten the
job done. I had to back out of 'libgpiod-2.1/tools' to
'~/libgpiod-2.1', and let './autogen.sh' take care of the '#define'...
instead of me trying to add it manually to 'gpioset.c' via '#define
GPIOSET_INTERACTIVE'.  I do have **all** the packages you listed below
installed, so why my manual addition didn't work is still a mystery to
me - but not one worth fretting over.

> That is with the following packages installed:
>  autoconf
>  autoconf-archive
>  libtool
>  m4
>  libedit-dev

Thanks for your help!   :)
~S

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Fri, Dec 29, 2023 at 07:50:21PM -0600, Seamus de Mora wrote:
> On Fri, Dec 29, 2023 at 9:58 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
>
> > This works for me on a Pi, both bullseye and bookworm:
> >
> > $ ./autogen.sh --enable-tools --enable-gpioset-interactive
> > $ make
>
> That option ('--enable-gpioset-interactive') seems to have gotten the
> job done. I had to back out of 'libgpiod-2.1/tools' to
> '~/libgpiod-2.1', and let './autogen.sh' take care of the '#define'...
> instead of me trying to add it manually to 'gpioset.c' via '#define
> GPIOSET_INTERACTIVE'.  I do have **all** the packages you listed below
> installed, so why my manual addition didn't work is still a mystery to
> me - but not one worth fretting over.
>

If you want to change build options then you need to re-run autogen.sh to
regenerate the Makefiles.

The option is mentioned in both TOOLS section of the README (but I note
has a typo that needs to be fixed) adjacent to the interactive example,
and the configure help, which is itself mentioned in the README:

$ ./configure --help

...

  --enable-gpioset-interactive
                          enable gpioset interactive mode [default=no]

...


That is not enabled by default as some platforms lack, or want to avoid
including, libedit.

> > That is with the following packages installed:
> >  autoconf
> >  autoconf-archive
> >  libtool
> >  m4
> >  libedit-dev
>
> Thanks for your help!   :)

And thank you for the SE un-upvote and downvote!

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Fri, Dec 29, 2023 at 8:21 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> > That option ('--enable-gpioset-interactive') seems to have gotten the
> > job done. I had to back out of 'libgpiod-2.1/tools' to
> > '~/libgpiod-2.1', and let './autogen.sh' take care of the '#define'...
> > instead of me trying to add it manually to 'gpioset.c' via '#define
> > GPIOSET_INTERACTIVE'.  I do have **all** the packages you listed below
> > installed, so why my manual addition didn't work is still a mystery to
> > me - but not one worth fretting over.
>
> If you want to change build options then you need to re-run autogen.sh to
> regenerate the Makefiles.
>
> The option is mentioned in both TOOLS section of the README (but I note
> has a typo that needs to be fixed) adjacent to the interactive example,
> and the configure help, which is itself mentioned in the README:
>
> $ ./configure --help
>

>   --enable-gpioset-interactive
>                           enable gpioset interactive mode [default=no]

>
> That is not enabled by default as some platforms lack, or want to avoid
> including, libedit.
>
> > Thanks for your help!   :)
>
> And thank you for the SE un-upvote and downvote!

Since you brought that up again: I did do an "un-upvote" - but not a
downvote (don't even know if that's possible). And I think you know
the reason I did: your haughty replies to my attempts at
communication. I really like to try to get along with everyone, but I
will admit I do not suffer arrogance well. After reviewing things, I
will say that I may have "crossed a line" with my use of the term
"can't be bothered"... I've used this term for much of my life, but
never realized it implied laziness until I looked it up yesterday. And
so for that - I apologize. If you'd like to now "bury the hatchet",
I'm good with that. If not - that's OK too.

~S

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Fri, Dec 29, 2023 at 10:43:16PM -0600, Seamus de Mora wrote:
> On Fri, Dec 29, 2023 at 8:21 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > > That option ('--enable-gpioset-interactive') seems to have gotten the
> > > job done. I had to back out of 'libgpiod-2.1/tools' to
> > > '~/libgpiod-2.1', and let './autogen.sh' take care of the '#define'...
> > > instead of me trying to add it manually to 'gpioset.c' via '#define
> > > GPIOSET_INTERACTIVE'.  I do have **all** the packages you listed below
> > > installed, so why my manual addition didn't work is still a mystery to
> > > me - but not one worth fretting over.
> >
> > If you want to change build options then you need to re-run autogen.sh to
> > regenerate the Makefiles.
> >
> > The option is mentioned in both TOOLS section of the README (but I note
> > has a typo that needs to be fixed) adjacent to the interactive example,
> > and the configure help, which is itself mentioned in the README:
> >
> > $ ./configure --help
> >
>
> >   --enable-gpioset-interactive
> >                           enable gpioset interactive mode [default=no]
>
> >
> > That is not enabled by default as some platforms lack, or want to avoid
> > including, libedit.
> >
> > > Thanks for your help!   :)
> >
> > And thank you for the SE un-upvote and downvote!
>
> Since you brought that up again: I did do an "un-upvote" - but not a
> downvote (don't even know if that's possible).

It is, and happened at exactly the same time as your un-upvote.
Weird that.

> And I think you know
> the reason I did: your haughty replies to my attempts at
> communication.

None of which had anything to with the quality of that answer, yet you
negged it anyway.  That is called spite.

> I really like to try to get along with everyone, but I
> will admit I do not suffer arrogance well.

As I have a very low tolerance for BS.

> After reviewing things, I
> will say that I may have "crossed a line" with my use of the term
> "can't be bothered"... I've used this term for much of my life, but
> never realized it implied laziness until I looked it up yesterday.

In what universe does "can't be bothered" imply anything BUT laziness
or complete indifference?
AIUI you are from the UK so you know that damn well.

> And
> so for that - I apologize. If you'd like to now "bury the hatchet",
> I'm good with that. If not - that's OK too.
>

Burying the hatchet sounds like a splendid idea, but actions count more
than words.

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Fri, Dec 29, 2023 at 11:03 PM Kent Gibson <warthog618@gmail.com> wrote:

> > > And thank you for the SE un-upvote and downvote!
> >
> > Since you brought that up again: I did do an "un-upvote" - but not a
> > downvote (don't even know if that's possible).
>
> It is, and happened at exactly the same time as your un-upvote.
> Weird that.

How did you determine this was at exactly the same time??

> In what universe does "can't be bothered" imply anything BUT laziness
> or complete indifference?
> AIUI you are from the UK so you know that damn well.

I can't explain it really - I just did not know.

> Burying the hatchet sounds like a splendid idea, but actions count more
> than words.

Agreed!

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Fri, Dec 29, 2023 at 11:45:59PM -0600, Seamus de Mora wrote:
> On Fri, Dec 29, 2023 at 11:03 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> > > > And thank you for the SE un-upvote and downvote!
> > >
> > > Since you brought that up again: I did do an "un-upvote" - but not a
> > > downvote (don't even know if that's possible).
> >
> > It is, and happened at exactly the same time as your un-upvote.
> > Weird that.
>
> How did you determine this was at exactly the same time??
>

Partly eyeballs - I saw it step.
Partly reputation history, though the timing resolution gets more coarse
as time passes.
And today after my email you undownvoted it, confirming that you did in
fact downvote it.

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Fri, Dec 29, 2023 at 11:53 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> And today after my email you undownvoted it, confirming that you did in
> fact downvote it.
>

I don't want to argue about this. What I did was restored my upvote.
Which I probably shouldn't have done b/c you left your snide remark in
your answer. Anyway - I don't know what to do about it...  does a
2-point downvote mean that much to you?

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Sat, Dec 30, 2023 at 12:25:17AM -0600, Seamus de Mora wrote:
> On Fri, Dec 29, 2023 at 11:53 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > And today after my email you undownvoted it, confirming that you did in
> > fact downvote it.
> >
>
> I don't want to argue about this. What I did was restored my upvote.
> Which I probably shouldn't have done b/c you left your snide remark in
> your answer. Anyway - I don't know what to do about it...  does a
> 2-point downvote mean that much to you?

Oh, so it's snide now, is it.  Unburying that hatchet?

Anyway, I couldn't care less - it was your actions that I found
informative.

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Sat, Dec 30, 2023 at 12:29 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Sat, Dec 30, 2023 at 12:25:17AM -0600, Seamus de Mora wrote:
> > On Fri, Dec 29, 2023 at 11:53 PM Kent Gibson <warthog618@gmail.com> wrote:
> > >
> > > And today after my email you undownvoted it, confirming that you did in
> > > fact downvote it.
> > >
> >
> > I don't want to argue about this. What I did was restored my upvote.
> > Which I probably shouldn't have done b/c you left your snide remark in
> > your answer. Anyway - I don't know what to do about it...  does a
> > 2-point downvote mean that much to you?
>
> Oh, so it's snide now, is it.  Unburying that hatchet?
>
> Anyway, I couldn't care less - it was your actions that I found
> informative.

:)  Kent, you're wearing me out, man.

But NO - NOT un-burying the hatchet, not un-downvoting what I didn't
downvote in the first place. I clicked a button three times: first was
to up-vote, next was to take the upvote away, 3rd was to restore the
upvote.  That is my total recollection - honest.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Sat, Dec 30, 2023 at 12:36:37AM -0600, Seamus de Mora wrote:
> On Sat, Dec 30, 2023 at 12:29 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Sat, Dec 30, 2023 at 12:25:17AM -0600, Seamus de Mora wrote:
> > > On Fri, Dec 29, 2023 at 11:53 PM Kent Gibson <warthog618@gmail.com> wrote:
> > > >
> > > > And today after my email you undownvoted it, confirming that you did in
> > > > fact downvote it.
> > > >
> > >
> > > I don't want to argue about this. What I did was restored my upvote.
> > > Which I probably shouldn't have done b/c you left your snide remark in
> > > your answer. Anyway - I don't know what to do about it...  does a
> > > 2-point downvote mean that much to you?
> >
> > Oh, so it's snide now, is it.  Unburying that hatchet?
> >
> > Anyway, I couldn't care less - it was your actions that I found
> > informative.
>
> :)  Kent, you're wearing me out, man.
>

Lightweight! ;-)

> But NO - NOT un-burying the hatchet, not un-downvoting what I didn't
> downvote in the first place. I clicked a button three times: first was
> to up-vote, next was to take the upvote away, 3rd was to restore the
> upvote.  That is my total recollection - honest.

In which case trying to upvote it again now would do nothing.
I'll bet you that isn't the case.

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Sat, Dec 30, 2023 at 12:43 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Sat, Dec 30, 2023 at 12:36:37AM -0600, Seamus de Mora wrote:
> > On Sat, Dec 30, 2023 at 12:29 AM Kent Gibson <warthog618@gmail.com> wrote:

> > But NO - NOT un-burying the hatchet, not un-downvoting what I didn't
> > downvote in the first place. I clicked a button three times: first was
> > to up-vote, next was to take the upvote away, 3rd was to restore the
> > upvote.  That is my total recollection - honest.
>
> In which case trying to upvote it again now would do nothing.
> I'll bet you that isn't the case.

There's only one way we're going to find that out. Edit your post &
remove "the remark". Afterwards, I'll **try** to upvote it. Warning:
"The system" doesn't allow dual upvotes, so don't try to hold me
accountable.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Kent Gibson]

On Sat, Dec 30, 2023 at 12:49:48AM -0600, Seamus de Mora wrote:
> On Sat, Dec 30, 2023 at 12:43 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Sat, Dec 30, 2023 at 12:36:37AM -0600, Seamus de Mora wrote:
> > > On Sat, Dec 30, 2023 at 12:29 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> > > But NO - NOT un-burying the hatchet, not un-downvoting what I didn't
> > > downvote in the first place. I clicked a button three times: first was
> > > to up-vote, next was to take the upvote away, 3rd was to restore the
> > > upvote.  That is my total recollection - honest.
> >
> > In which case trying to upvote it again now would do nothing.
> > I'll bet you that isn't the case.
>
> There's only one way we're going to find that out. Edit your post &
> remove "the remark". Afterwards, I'll **try** to upvote it. Warning:
> "The system" doesn't allow dual upvotes, so don't try to hold me
> accountable.

Do keep up - I've already done that.

Cheers,
Kent.

Re: [libgpiod] help with GPIOSET_INTERACTIVE

[Seamus de Mora]

On Sat, Dec 30, 2023 at 12:51 AM Kent Gibson <warthog618@gmail.com> wrote:

>
> Do keep up - I've already done that.
>

Well I'll be damned... I don't know what happened, but YOU WERE RIGHT
AND I WAS WRONG.

Enjoy it man - you've earned it :)