From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Peng Fan <peng.fan@nxp.com>,
"andreas@kemnade.info" <andreas@kemnade.info>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"olof@lixom.net" <olof@lixom.net>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"prabhakar.mahadev-lad.rj@bp.renesas.com"
<prabhakar.mahadev-lad.rj@bp.renesas.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"lkundrak@v3.sk" <lkundrak@v3.sk>,
"joel@jms.id.au" <joel@jms.id.au>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
Leo Li <leoyang.li@nxp.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"michael@walle.cc" <michael@walle.cc>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default
Date: Wed, 16 Sep 2020 08:03:49 +0200 [thread overview]
Message-ID: <CAJKOXPd-VZAOcezOS5-18te6OQZ53BU24su3WmAf+=Gtt8aBtw@mail.gmail.com> (raw)
In-Reply-To: <DB3PR0402MB39168692AC262B7BFA21D0C0F5210@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Wed, 16 Sep 2020 at 03:59, Anson Huang <anson.huang@nxp.com> wrote:
>
> Hi, Krzysztof
>
> > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in
> > CONFIG_GPIO_MXC by default
> >
> > On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@nxp.com>
> > wrote:
> > >
> > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> > > built-in manually.
> >
> > Maybe it should stay not enabled? Please explain in commit msg why it should
> > be enabled.
>
> The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic
> function of GPIO pin operations and IRQ operations, it is enabled by default previously
> with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly
> enabled in defconfig to make sure it does NOT break any existing functions, that is
> why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> built-in manually " in commit msg, it aims to NOT change any previous behaviors.
Sure, I was just saying that all this should be in commit msg. The
commit should explain why it is there in the Linux kernel.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-09-16 6:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 3:29 [PATCH V2 RESEND 1/4] gpio: mxc: Support module build Anson Huang
2020-09-14 3:29 ` [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default Anson Huang
2020-09-15 15:58 ` Krzysztof Kozlowski
2020-09-16 1:59 ` Anson Huang
2020-09-16 6:03 ` Krzysztof Kozlowski [this message]
2020-09-14 3:29 ` [PATCH V2 RESEND 3/4] ARM: imx_v6_v7_defconfig: " Anson Huang
2020-09-14 3:29 ` [PATCH V2 RESEND 4/4] ARM: multi_v7_defconfig: " Anson Huang
2020-09-15 15:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPd-VZAOcezOS5-18te6OQZ53BU24su3WmAf+=Gtt8aBtw@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=andreas@kemnade.info \
--cc=anson.huang@nxp.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil-cisco@xs4all.nl \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=michael@walle.cc \
--cc=oleksandr.suvorov@toradex.com \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).