From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E900C43461 for ; Wed, 16 Sep 2020 06:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D63A221E3 for ; Wed, 16 Sep 2020 06:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600236245; bh=MGLUFXU7bgEiOq2QwCLtokuXU6KQpofMXm9tQrG1+AA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=bhLIfpjShQCaLt3NiNsLRhH+T0y3qaIhss2TQ4Nz1TUd9WqAHcS0bs3ElQzq4Ldrs 1ReUl3OCOLTWC2fiHKaCyhfTrqoD5dhYbaA5EtvPsyKkTcErDBK50jDOiCLvfwigkX V0VMM3X1DV1I4+sZV6BvMhYPeERqEA/LWCH9dOZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgIPGEE (ORCPT ); Wed, 16 Sep 2020 02:04:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:39288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726093AbgIPGEE (ORCPT ); Wed, 16 Sep 2020 02:04:04 -0400 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 257AB2220E; Wed, 16 Sep 2020 06:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600236243; bh=MGLUFXU7bgEiOq2QwCLtokuXU6KQpofMXm9tQrG1+AA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xu9fAoLMxR+Sbne3nolGsptpoYBDPw5I5CfHKOMDdMWT0Fz/JyJVq6/ylx7FJzdOf x4/Kf10phhEzTQnup4DRMwW21ZWts2uITWbwa7Gj4pcZZB3kCEofefRTFqVTvzCZgB L02kMFOYEVDi3qDPM8ksi9I9Ys65VVf7t7YZO/r4= Received: by mail-ed1-f46.google.com with SMTP id n22so5050347edt.4; Tue, 15 Sep 2020 23:04:03 -0700 (PDT) X-Gm-Message-State: AOAM531B78Ia81StDogJYBq46fGvzRYnpYrPLmsX+50GHNX/zSGjj7B+ wr+pSELRIO6KagrAHVA9NlNUC7EjbXLCuF8D80Q= X-Google-Smtp-Source: ABdhPJzf7bf8D+dhy3zqQalV6k7pR+DsnqPe6uDFJBoNyVs7vkIF4YE5WM1N/PIcrsuSHlEipJiegQiLr568kZELN94= X-Received: by 2002:a05:6402:ca7:: with SMTP id cn7mr25423402edb.143.1600236241549; Tue, 15 Sep 2020 23:04:01 -0700 (PDT) MIME-Version: 1.0 References: <1600054147-29997-1-git-send-email-Anson.Huang@nxp.com> <1600054147-29997-2-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 16 Sep 2020 08:03:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default To: Anson Huang Cc: "linux@armlinux.org.uk" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "oleksandr.suvorov@toradex.com" , Peng Fan , "andreas@kemnade.info" , "hverkuil-cisco@xs4all.nl" , "olof@lixom.net" , "geert+renesas@glider.be" , "prabhakar.mahadev-lad.rj@bp.renesas.com" , Aisheng Dong , "lkundrak@v3.sk" , "joel@jms.id.au" , "bjorn.andersson@linaro.org" , Leo Li , "vkoul@kernel.org" , "michael@walle.cc" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 16 Sep 2020 at 03:59, Anson Huang wrote: > > Hi, Krzysztof > > > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in > > CONFIG_GPIO_MXC by default > > > > On Mon, 14 Sep 2020 at 05:36, Anson Huang > > wrote: > > > > > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > > > built-in manually. > > > > Maybe it should stay not enabled? Please explain in commit msg why it should > > be enabled. > > The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic > function of GPIO pin operations and IRQ operations, it is enabled by default previously > with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly > enabled in defconfig to make sure it does NOT break any existing functions, that is > why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > built-in manually " in commit msg, it aims to NOT change any previous behaviors. Sure, I was just saying that all this should be in commit msg. The commit should explain why it is there in the Linux kernel. Best regards, Krzysztof